Remove ETSY and EUW from websites and add one.lt #2171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EUW could be reintroduced with the addition of #2169 or #2170, but I would suggest it being replaced with https://www.leagueofgraphs.com/ site which has a more straight forward way of displaying that an account is not found. |
|
Failed test due to down remote target. Other tests pass. |
|
This has been merged into master. GitHub just isn't picking it up after some annoying merge conflict resolution. Welcome to the contributor tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ETSY because HTTP request returns 403 Forbidden in all cases and EUW because user-tag is needed to search from websites and add one.lt