Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make prune only removes this project's volumes #73

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

gluckzhang
Copy link
Contributor

@gluckzhang gluckzhang commented Apr 27, 2022

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

Adjust the Makefile and let make prune only delete the volumes created by this docker-compose project. The following command works:

docker volume prune -f --filter label=com.docker.compose.project=elastic

Does this close any currently open issues?

Yes, this closes #72 .

Any relevant logs, error output, etc?

Not necessary in this case.

Where has this been tested?

In my local environment.

@sherifabdlnaby sherifabdlnaby merged commit 6549c65 into sherifabdlnaby:main Apr 29, 2022
@sherifabdlnaby
Copy link
Owner

@gluckzhang Thank you for finding and fixing this one! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make prune will remove all the currently unused volumes
2 participants