Fix default manifest file mapping (path to name) #71
Conversation
|
Thank you @frequin , I think you are right, I must have inverted something here... But it's not in the |
|
@mastilver rebased and fixed. I'll add a test asap. |
|
Great! :) I think minimal test would be to copy https://github.com/danethurber/webpack-manifest-plugin/blob/43b48f1eab84d718439383fa52a683c79e237fab/spec/plugin.spec.js#L345-L363 and add |
Codecov Report
@@ Coverage Diff @@
## 1.x #71 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 2 2
Lines 75 75
=======================================
Hits 74 74
Misses 1 1
Continue to review full report at Codecov.
|
spec/plugin.spec.js
Outdated
| expect(manifest).toBeDefined(); | ||
| expect(manifest).toEqual({ | ||
| 'main.js': 'main.js', | ||
| 'file.txt': assetOutputFilename |
There was a problem hiding this comment.
'file.txt': stats.hash + '.txt'
There was a problem hiding this comment.
Well stats.hash is related to the bundle hash while [hash] from the file-loader name is related to the file content. So it does not fit.
Do you see another way ?
There was a problem hiding this comment.
Or instead of a hash, I can use file-loader?name=outputfile.[ext] ? What do you think ?
There was a problem hiding this comment.
As long as key and value are different, I'm happy :)
|
@mastilver There it is :) |
|
Great, Thank you @frequin |
closes #70