Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default filename from 'manifest.json' to 'manifest.webmanifest' #106

Closed
wants to merge 1 commit into from

Conversation

mojoaxel
Copy link

Thanks for this plugin! 👍

This pull requests changes the default filename from manifest.json to manifest.webmanifest because this is (now) the recommended filename and extension by the W3C:

Here is the discussion:

Some browser vendors also already adopted there docs:

I would consider this a major change so maybe this is something for the major 2.0 release?

@codecov-io
Copy link

codecov-io commented Nov 21, 2017

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78
Impacted Files Coverage Δ
lib/plugin.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409b0fb...46cc61a. Read the comment docs.

@mojoaxel
Copy link
Author

Sorry my mistake. Wrong manifest.json ;-)

@mojoaxel mojoaxel closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants