Fix types and make sure Typescript types validate #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are unrelated and due to outdated dependencies |
|
@realityking thanks for the PR. I just updated master with update dependencies. Please merge from upstream/master so that CI will pass. |
This was referenced Mar 30, 2021
|
@shellscape any chance we could get a new release with this change? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Currently types in this package are not valid breaking any consumer of this package that uses typescript. dependents/node-detective-postcss#107 is where I ran into this issue.
As it turns out, part of the issue that not all necessary types are exported by PostCSS. I will create a PR there to address that. You might want to keep this open until this is (partially) fixed upstream.
I've also added a CI check to validate the types. While it won't be able to check for correctness of the types, this will make sure any references to PostCSS types resolve.