Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hwb, lab, and lch to functions matching isColor #111

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Add hwb, lab, and lch to functions matching isColor #111

merged 3 commits into from
Apr 18, 2020

Conversation

jonathantneal
Copy link
Collaborator

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

This PR changes the way the isColor property of a Func is determined so that it may include hwb(), lch(), and lab() notations.


Note: This is not causing me any issues in my current work. It’s just something I noticed while inspecting the code.

Note: I would expect the isColor and isVar helper properties to be getters, so that in the event one reassigns a function name, they remain accurate. I am open to adding that in a separate PR if you feel it will add value.

@jonathantneal jonathantneal marked this pull request as ready for review April 17, 2020 22:10
@shellscape
Copy link
Owner

Thanks! I'll get this merged and released tonight

@jonathantneal
Copy link
Collaborator Author

Sweet! I’ll follow along. 👍 Thanks a ton!

@shellscape shellscape merged commit 9189daa into shellscape:master Apr 18, 2020
@shellscape
Copy link
Owner

Sorry for not getting this published last night. Came down with something and just woke up a bit ago. Looks like I just needed sleep. I have a few tweaks I want to make and then I'll get a new version out.

@shellscape
Copy link
Owner

Note: I would expect the isColor and isVar helper properties to be getters, so that in the event one reassigns a function name, they remain accurate. I am open to adding that in a separate PR if you feel it will add value.

I'm open to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants