-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace url-regex and is-url-superb with custom implementation #120
Comments
As a workaround, maybe it could be an option to replace |
This solves some security issues. Only one remain: shellscape/postcss-values-parser#120
@jhuesos looks good 👍 |
@jhuesos Yes that sounds good. Note that |
This comment has been minimized.
This comment has been minimized.
@Hypnosphi Unfortunately upgrading to that version isn't an option here because the new version doesn't class protocol-relative URLs as valid. See the original comment on this issue for more. |
Can be closed after #125 |
Feature Use Case
There is an open security vulnerability in
url-regex
(kevva/url-regex#70) and no patch available. Theurl-regex
dependency isn't actually used by this package but even if it was removed, it would still be required further down the dependency tree byis-url-superb
. It has been removed as a dependency of that package but upgrading isn't an option as that package now doesn't class protocol-relative URLs as valid. Protocol-relative URLs are valid in CSS so we want to allow them in this package. See #119 for more discussion.Feature Proposal
isUrl
check in this packageis-url-superb
andurl-regex
dependenciesThe text was updated successfully, but these errors were encountered: