fix: sed works with slashes in regex #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,10 +37,13 @@ export const shx = (argv) => { | |||
| newArgs = []; | |||
| let lookingForSubstString = true; | |||
| args.forEach((arg) => { | |||
| const match = arg.match(/^s\/(.*)\/(.*)\/(g?)$/); | |||
| const match = arg.match(/^s\/(.*[^\\])\/(.*[^\\])\/(g?)$/); | |||
There was a problem hiding this comment.
Shouldn't this be /^s\/([^\\.]*)\/([^\\.]*)\/(g?)$/?
There was a problem hiding this comment.
@ariporad A sed-regex is allowed to have backslashes in it, but it's not allowed to end in a backslash. The end of a sed-regex is designated by the first appearance of a non-escaped /. If you want to include a / in the regex, you would use \/. I think your JS-regex would prevent that from working.
Current coverage is 85.00% (diff: 100%)@@ master #77 diff @@
==========================================
Files 2 2
Lines 18 20 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 15 17 +2
Misses 3 3
Partials 0 0
|
|
LGTM! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make
shx sedwork a little bit better. Also, this should make the code a bit more readable. If you have any readability suggestions, chime in and I'll implement those.