Merge dev into master #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add newline to output of echo * Add test
* Split on newlines only * Only split lines if need be * Clarify code by making use of Array.prototype.reduce
* Add newline to output of echo (#557) * Add newline to output of echo * Add test * Throw an error if the options string does not start with '-' (#615) * Throw an error if the options string does not start with '-' * Add test * Change message grammar * Add -n option to echo * Fix null argument issue * Add -n tests * Add documentation * Add -en escaped character test * Add function to parse options for echo * Use parseOptions to parse echo options * Simplify control flow * parseOptions throws now * Allow null to be echoed * Prevent echo stderr on unrecognized option * Add test to check stderr of returned value * Use consistent variable name * Change test message, leave TODO about console output
* Add stdout/stderr test mocks * Mock stdout/stderr during echo tests * Fix lint issues * Use 'use strict' * Re-implement mocks as a prototype * Implement mocks as a single-instance * Remove redundant test * Create mocked stdout/stderr.write methods once
|
Here's the list of PRs that found their way onto dev branch. We'll want to make sure all of these are reflected on this new dev branch. |
* Deprecate common.getUserHome, advise using os.homedir instead * Remove common.getUserHome
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 94.81% 96.65% +1.84%
==========================================
Files 33 33
Lines 1254 1227 -27
==========================================
- Hits 1189 1186 -3
+ Misses 65 41 -24
Continue to review full report at Codecov.
|
|
Expanded list:
|
nfischer
approved these changes
Jun 7, 2017
There was a problem hiding this comment.
The coverage drops are reasonable as long as we work to get those lines covered in future PRs. I just released v0.7.8 (last main patch to v0.7.x), so I'm going to go ahead and land this.
@freitagbr thanks for your hard work!
This was referenced Jun 7, 2017
Closed
This was referenced Aug 29, 2019
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #650 but with the merge conflicts resolved.