test: refactor 'set' tests to AVA #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freitagbr
requested changes
Nov 24, 2016
| }); | ||
|
|
||
| const nodeVersion = process.versions.node.split('.').map(str => parseInt(str, 10)); | ||
| const uncaughtErrorExitCode = (nodeVersion[0] === 0 && nodeVersion[1] < 11) ? 8 : 1; |
There was a problem hiding this comment.
Move these up a few lines with the other const declaration.
There was a problem hiding this comment.
This is some legacy stuff. More of our stuff breaks on v0.10, and even this code doesn't work on v0.8, so I'm just taking it out. The value for v0.11+ is 1.
nfischer
force-pushed
the
test-ava-set
branch
from
3a02b4b
to
164347a
Compare
|
@freitagbr PTAL |
nfischer
changed the title
|
LGTM |
|
@freitagbr can you approve the changes? |
freitagbr
approved these changes
Nov 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR, so double check that I got all the test cases. I'll follow up once I've verified that this translates everything correctly.