Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase mongodb version #443

Merged
merged 5 commits into from
Nov 22, 2023
Merged

feat: increase mongodb version #443

merged 5 commits into from
Nov 22, 2023

Conversation

icco
Copy link
Contributor

@icco icco commented Nov 22, 2023

@icco icco marked this pull request as ready for review November 22, 2023 14:00
@vladholubiev
Copy link
Member

@harazdovskiy could you please take a look if nothing breaks, tests pass, and publish a new version?

@harazdovskiy harazdovskiy self-requested a review November 22, 2023 22:09
@harazdovskiy
Copy link
Contributor

Checked locally, merging! Thanks @icco for being patient and crafting this pull request❤️

CleanShot 2023-11-23 at 00 57 15@2x

@harazdovskiy harazdovskiy merged commit 09b0fd1 into shelfio:master Nov 22, 2023
@harazdovskiy
Copy link
Contributor

harazdovskiy commented Nov 22, 2023

@icco you can try changes in v4.2.0

@icco icco deleted the mongo6 branch November 23, 2023 16:01
@icco
Copy link
Contributor Author

icco commented Nov 23, 2023

Thank you!

@erosval
Copy link

erosval commented Nov 24, 2023

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

@icco
Copy link
Contributor Author

icco commented Nov 24, 2023

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

Did you follow Mongo's upgrade documentation? https://www.mongodb.com/docs/drivers/node/current/upgrade/#version-6.x-breaking-changes we're still rolling out, but some of the return objects have changed.

@erosval
Copy link

erosval commented Nov 24, 2023

Yes of course, when I run tests on a real mongodb database (v.7) everything works as expected

@icco
Copy link
Contributor Author

icco commented Nov 24, 2023

Interesting, I haven't seen that yet. Let's create a new issue and try and figure it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies for mongodb@6 and higher
4 participants