-
Notifications
You must be signed in to change notification settings - Fork 297
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add vim-sensible defaults by default
- Loading branch information
Showing
1 changed file
with
128 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
233a817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't appreciate putting sensible settings in this plugin. When a user can't figure out why his/her own setting in the vimrc doesn't work, the only way he/she could figure out the problem is by disabling each plugin and identify that it's this plugin overwriting the setting. tpope/vim-sensible explicitly tells you that he's changing your settings, while you just mention this vaguely in the README in one sentence. And you never know what side effect can happen if you change users' settings. In fact, this commit breaks vim-netranger such that I need to add a new patch to fix it. It's very time-consuming to identify plugin conflict like this and I guess the best way is to leave user's global settings alone unless they know very clearly that this plugins is changing their settings.
233a817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, I'll leave only polyglot related things
233a817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ipod825 @gwarf Could you look at 1d7f0e4 ? Anything else to remove?
233a817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see "set incsearch" removed. I always use "set noincsearch" in my .vimrc, and polyglot is overriding that now.