Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Missing firework recipes #333

Closed
ChabaneAmaury opened this issue May 2, 2020 · 5 comments
Closed

[Feature] Missing firework recipes #333

ChabaneAmaury opened this issue May 2, 2020 · 5 comments
Labels
enhancement New feature or request note: pending release This issue has been resolved in development versions of REI

Comments

@ChabaneAmaury
Copy link

Describe the bug
Some items are missing recipes

Steps to Reproduce
I have currently in mind the firework rocket:

  • Go in your inventory and search for the firework rocket
  • Try to show the recipe

Environment (please complete the following information with the version):

  • Minecraft: 1.15.2
  • Mod Loader: fabric

Logs
latest.log

@ChabaneAmaury ChabaneAmaury added the bug Something isn't working label May 2, 2020
@shedaniel
Copy link
Owner

Fireworks doesn't relay on normal json recipes, which is why you don't see it in recipe books as well, I need to hardcode if I am implementing this

@shedaniel shedaniel added enhancement New feature or request status: wontfix This will not be worked on and removed bug Something isn't working labels May 2, 2020
@ChabaneAmaury
Copy link
Author

Oh ok I see. You sure there isn't another way ? Because I remember it was in NEI some time ago, so I guess there still is another way (with changing crafts like the wiki)

@shedaniel shedaniel changed the title [Bug] Missing recipes [Bug] Missing firework recipes May 8, 2020
@shedaniel shedaniel changed the title [Bug] Missing firework recipes [Feature] Missing firework recipes May 8, 2020
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

This issue is marked with stale as this issue had no activity in 60 days. This issue will not be automatically closed.

@github-actions github-actions bot added the stale label Jul 8, 2020
@MorningSage
Copy link

I was going to open another issue for this, but I'm not sure if this also falls under the "wontfix" portion?

On the Forge version, the plain fireworks recipe does not show up at all. Fabric at least shows something, but while using Forge, hovering over the fireworks item in REI and hitting R does not do anything.

Shall I open an issue for this as I'd expect at least one to show up on Forge like it does on Fabric? Or is this a difference in recipe handling between the modloaders and not something to address?

@shedaniel
Copy link
Owner

The Forge specific issue is not related to this issue.

@shedaniel shedaniel removed the stale label Feb 14, 2022
shedaniel added a commit that referenced this issue Dec 24, 2022
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
@shedaniel shedaniel added the note: pending release This issue has been resolved in development versions of REI label Dec 24, 2022
@shedaniel shedaniel added this to the REI 8.4 milestone Dec 24, 2022
@shedaniel shedaniel removed the status: wontfix This will not be worked on label Dec 24, 2022
shedaniel added a commit that referenced this issue Dec 25, 2022
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
@shedaniel shedaniel reopened this Jun 1, 2023
shedaniel added a commit that referenced this issue Jun 1, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Jul 16, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Sep 1, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Oct 18, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Oct 24, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Nov 5, 2023
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Apr 15, 2024
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
shedaniel added a commit that referenced this issue Apr 15, 2024
…ook, Firework Rocket, Clone Map, Extend Map, Decorate Shield, Dye Shulker Box, Suspicious Stew)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request note: pending release This issue has been resolved in development versions of REI
Projects
None yet
Development

No branches or pull requests

3 participants