Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/11.x-1.19.4' into 12.x-1.20
Browse files Browse the repository at this point in the history
# Conflicts:
#	default-plugin/src/main/java/me/shedaniel/rei/plugin/common/displays/DefaultSmithingDisplay.java
#	fabric/src/main/resources/roughlyenoughitems.accessWidener
#	forge/src/main/resources/META-INF/accesstransformer.cfg
  • Loading branch information
shedaniel committed Sep 17, 2024
2 parents 97adf5d + b666943 commit ccf3dcd
Show file tree
Hide file tree
Showing 27 changed files with 1,116 additions and 236 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@

import me.shedaniel.math.Rectangle;
import me.shedaniel.rei.api.common.entry.EntryStack;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.Nullable;

import java.util.Collection;
import java.util.List;
import java.util.function.Consumer;

public abstract class Slot extends WidgetWithBounds {
public static final byte UN_MARKED = 0;
Expand Down Expand Up @@ -133,6 +135,10 @@ public final Slot disableBackground() {

public abstract Slot entries(Collection<? extends EntryStack<?>> stacks);

@ApiStatus.Experimental
@ApiStatus.Internal
public abstract Slot withEntriesListener(Consumer<Slot> listener);

public abstract EntryStack<?> getCurrentEntry();

public abstract List<EntryStack<?>> getEntries();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
package me.shedaniel.rei.api.common.plugins;

import me.shedaniel.rei.api.client.plugins.REIClientPlugin;
import me.shedaniel.rei.api.common.registry.ReloadStage;
import me.shedaniel.rei.impl.ClientInternals;
import me.shedaniel.rei.impl.Internals;
import me.shedaniel.rei.impl.common.plugins.PluginReloadContext;
import net.fabricmc.api.EnvType;
import net.fabricmc.api.Environment;
import org.jetbrains.annotations.ApiStatus;
Expand Down Expand Up @@ -62,18 +62,25 @@ public void registerPlugin(REIPluginProvider<? extends P> plugin) {
}

@Override
public void pre(ReloadStage stage) {
PluginView.this.pre(stage);
public void pre(PluginReloadContext context) throws InterruptedException {
PluginView.this.pre(context);
}

@Override
public void post(ReloadStage stage) {
PluginView.this.post(stage);
public void reload(PluginReloadContext context) throws InterruptedException {
PluginView.this.reload(context);
}

@Override
public void post(PluginReloadContext context) throws InterruptedException {
PluginView.this.post(context);
}
};
}

void pre(ReloadStage stage);
void pre(PluginReloadContext context) throws InterruptedException;

void reload(PluginReloadContext context) throws InterruptedException;

void post(ReloadStage stage);
void post(PluginReloadContext context) throws InterruptedException;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* This file is licensed under the MIT License, part of Roughly Enough Items.
* Copyright (c) 2018, 2019, 2020, 2021, 2022, 2023 shedaniel
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/

package me.shedaniel.rei.impl.common.plugins;

import me.shedaniel.rei.api.common.registry.ReloadStage;
import org.jetbrains.annotations.ApiStatus;

@ApiStatus.Internal
public interface PluginReloadContext {
ReloadStage stage();

ReloadInterruptionContext interruptionContext();

static PluginReloadContext of(ReloadStage stage, ReloadInterruptionContext interruptionContext) {
return new PluginReloadContext() {
@Override
public ReloadStage stage() {
return stage;
}

@Override
public ReloadInterruptionContext interruptionContext() {
return interruptionContext;
}
};
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* This file is licensed under the MIT License, part of Roughly Enough Items.
* Copyright (c) 2018, 2019, 2020, 2021, 2022, 2023 shedaniel
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/

package me.shedaniel.rei.impl.common.plugins;

import me.shedaniel.rei.impl.common.InternalLogger;
import org.jetbrains.annotations.ApiStatus;

@FunctionalInterface
@ApiStatus.Internal
public interface ReloadInterruptionContext {
boolean isInterrupted();

default void checkInterrupted() throws InterruptedException {
if (isInterrupted()) {
InternalLogger.getInstance().debug("Plugin reload interrupted!");
throw new InterruptedException();
}
}

default ReloadInterruptionContext withJob(Runnable ifInterrupted) {
return new ReloadInterruptionContext() {
@Override
public boolean isInterrupted() {
return ReloadInterruptionContext.this.isInterrupted();
}

@Override
public void checkInterrupted() throws InterruptedException {
try {
ReloadInterruptionContext.this.checkInterrupted();
} catch (InterruptedException e) {
ifInterrupted.run();
throw e;
}
}
};
}

static ReloadInterruptionContext ofNever() {
return () -> false;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,22 @@
import me.shedaniel.math.Point;
import me.shedaniel.math.Rectangle;
import me.shedaniel.rei.api.client.gui.Renderer;
import me.shedaniel.rei.api.client.gui.widgets.Slot;
import me.shedaniel.rei.api.client.gui.widgets.Widget;
import me.shedaniel.rei.api.client.gui.widgets.Widgets;
import me.shedaniel.rei.api.client.registry.display.DisplayCategory;
import me.shedaniel.rei.api.common.category.CategoryIdentifier;
import me.shedaniel.rei.api.common.display.basic.BasicDisplay;
import me.shedaniel.rei.api.common.entry.EntryIngredient;
import me.shedaniel.rei.api.common.entry.EntryStack;
import me.shedaniel.rei.api.common.util.EntryStacks;
import me.shedaniel.rei.plugin.common.BuiltinPlugin;
import me.shedaniel.rei.plugin.common.displays.DefaultSmithingDisplay;
import net.minecraft.core.RegistryAccess;
import net.minecraft.network.chat.Component;
import net.minecraft.world.level.block.Blocks;
import org.apache.commons.lang3.mutable.MutableBoolean;
import org.jetbrains.annotations.ApiStatus;

import java.util.List;

Expand Down Expand Up @@ -65,19 +72,38 @@ public List<Widget> setupDisplay(DefaultSmithingDisplay display, Rectangle bound
widgets.add(Widgets.createArrow(new Point(startPoint.x + 27 + offsetX, startPoint.y + 4)));
widgets.add(Widgets.createResultSlotBackground(new Point(startPoint.x + 61 + offsetX, startPoint.y + 5)));
if (!legacy) {
widgets.add(Widgets.createSlot(new Point(startPoint.x + 4 - 18 * 2 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(0)).markInput());
widgets.add(Widgets.createSlot(new Point(startPoint.x + 4 - 18 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(1)).markInput());
widgets.add(Widgets.createSlot(new Point(startPoint.x + 4 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(2)).markInput());
Slot templateSlot, baseSlot, additionSlot, resultSlot;
MutableBoolean dirty = new MutableBoolean(true);
widgets.add(templateSlot = Widgets.createSlot(new Point(startPoint.x + 4 - 18 * 2 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(0)).withEntriesListener(slot -> dirty.setTrue()).markInput());
widgets.add(baseSlot = Widgets.createSlot(new Point(startPoint.x + 4 - 18 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(1)).withEntriesListener(slot -> dirty.setTrue()).markInput());
widgets.add(additionSlot = Widgets.createSlot(new Point(startPoint.x + 4 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(2)).withEntriesListener(slot -> dirty.setTrue()).markInput());
widgets.add(resultSlot = Widgets.createSlot(new Point(startPoint.x + 61 + offsetX, startPoint.y + 5)).entries(display.getOutputEntries().get(0)).disableBackground().markOutput());
widgets.add(Widgets.createDrawableWidget((graphics, mouseX, mouseY, delta) -> {
if (dirty.booleanValue()) {
resultSlot.clearEntries().entries(getOutput(display, BasicDisplay.registryAccess(), templateSlot.getCurrentEntry(), baseSlot.getCurrentEntry(), additionSlot.getCurrentEntry()));
dirty.setFalse();
}
}));
} else {
widgets.add(Widgets.createSlot(new Point(startPoint.x + 4 - 22 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(0)).markInput());
widgets.add(Widgets.createSlot(new Point(startPoint.x + 4 + offsetX, startPoint.y + 5)).entries(display.getInputEntries().get(1)).markInput());
widgets.add(Widgets.createSlot(new Point(startPoint.x + 61 + offsetX, startPoint.y + 5)).entries(display.getOutputEntries().get(0)).disableBackground().markOutput());
}
widgets.add(Widgets.createSlot(new Point(startPoint.x + 61 + offsetX, startPoint.y + 5)).entries(display.getOutputEntries().get(0)).disableBackground().markOutput());
return widgets;
}

@Override
public int getDisplayHeight() {
return 36;
}

@ApiStatus.Experimental
private static EntryIngredient getOutput(DefaultSmithingDisplay display, RegistryAccess registryAccess, EntryStack<?> template, EntryStack<?> base, EntryStack<?> addition) {
if (display.getType() == DefaultSmithingDisplay.SmithingRecipeType.TRIM) {
EntryIngredient output = DefaultSmithingDisplay.getTrimmingOutput(registryAccess, template, base, addition);
if (!output.isEmpty()) return output;
}

return display.getOutputEntries().get(0);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import me.shedaniel.rei.api.common.category.CategoryIdentifier;
import me.shedaniel.rei.api.common.display.basic.BasicDisplay;
import me.shedaniel.rei.api.common.entry.EntryIngredient;
import me.shedaniel.rei.api.common.entry.EntryStack;
import me.shedaniel.rei.api.common.entry.type.VanillaEntryTypes;
import me.shedaniel.rei.api.common.util.EntryIngredients;
import me.shedaniel.rei.api.common.util.EntryStacks;
import me.shedaniel.rei.plugin.common.BuiltinPlugin;
Expand All @@ -38,12 +40,16 @@
import net.minecraft.world.item.crafting.SmithingTransformRecipe;
import net.minecraft.world.item.crafting.SmithingTrimRecipe;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.Nullable;

import java.util.ArrayList;
import java.util.List;
import java.util.Optional;

public class DefaultSmithingDisplay extends BasicDisplay {
@Nullable
private final SmithingRecipeType type;

@ApiStatus.Experimental
public DefaultSmithingDisplay(SmithingTransformRecipe recipe) {
this(
Expand Down Expand Up @@ -82,25 +88,15 @@ public static List<DefaultSmithingDisplay> from(SmithingTrimRecipe recipe) {
.orElse(null);
if (trimMaterial == null) continue;

ArmorTrim armorTrim = new ArmorTrim(trimMaterial, trimPattern);
EntryIngredient.Builder baseItems = EntryIngredient.builder(), outputItems = EntryIngredient.builder();
for (ItemStack item : recipe.base.getItems()) {
Optional<ArmorTrim> trim = ArmorTrim.getTrim(registryAccess, item);
if (trim.isEmpty() || !trim.get().hasPatternAndMaterial(trimPattern, trimMaterial)) {
ItemStack newItem = item.copy();
newItem.setCount(1);
if (ArmorTrim.setTrim(registryAccess, newItem, armorTrim)) {
baseItems.add(EntryStacks.of(item.copy()));
outputItems.add(EntryStacks.of(newItem));
}
}
}
EntryIngredient baseIngredient = EntryIngredients.ofIngredient(recipe.base);
EntryIngredient templateOutput = baseIngredient.isEmpty() ? EntryIngredient.empty()
: getTrimmingOutput(registryAccess, EntryStacks.of(templateItem), baseIngredient.get(0), EntryStacks.of(additionStack));

displays.add(new DefaultSmithingDisplay(List.of(
EntryIngredients.of(templateItem),
baseItems.build(),
baseIngredient,
EntryIngredients.of(additionStack)
), List.of(outputItems.build()),
Optional.ofNullable(recipe.getId())));
), List.of(templateOutput), SmithingRecipeType.TRIM, Optional.ofNullable(recipe.getId())));
}
}
return displays;
Expand All @@ -115,15 +111,61 @@ public DefaultSmithingDisplay(SmithingRecipe recipe, List<EntryIngredient> input
}

public DefaultSmithingDisplay(List<EntryIngredient> inputs, List<EntryIngredient> outputs, Optional<ResourceLocation> location) {
this(inputs, outputs, null, location);
}

@ApiStatus.Experimental
public DefaultSmithingDisplay(List<EntryIngredient> inputs, List<EntryIngredient> outputs, @Nullable SmithingRecipeType type, Optional<ResourceLocation> location) {
super(inputs, outputs, location);
this.type = type;
}

@Override
public CategoryIdentifier<?> getCategoryIdentifier() {
return BuiltinPlugin.SMITHING;
}

@ApiStatus.Experimental
@Nullable
public SmithingRecipeType getType() {
return type;
}

public static BasicDisplay.Serializer<DefaultSmithingDisplay> serializer() {
return BasicDisplay.Serializer.ofSimple(DefaultSmithingDisplay::new);
return BasicDisplay.Serializer.of((input, output, id, tag) -> {
SmithingRecipeType type = tag.contains("Type") ? SmithingRecipeType.valueOf(tag.getString("Type")) : null;
return new DefaultSmithingDisplay(input, output, type, id);
}, (display, tag) -> {
if (display.type != null) tag.putString("Type", display.type.name());
});
}

@ApiStatus.Experimental
public enum SmithingRecipeType {
TRIM,
TRANSFORM
}

@ApiStatus.Experimental
@ApiStatus.Internal
public static EntryIngredient getTrimmingOutput(RegistryAccess registryAccess, EntryStack<?> template, EntryStack<?> base, EntryStack<?> addition) {
if (template.getType() != VanillaEntryTypes.ITEM || base.getType() != VanillaEntryTypes.ITEM || addition.getType() != VanillaEntryTypes.ITEM) return EntryIngredient.empty();
ItemStack templateItem = template.castValue();
ItemStack baseItem = base.castValue();
ItemStack additionItem = addition.castValue();
Holder.Reference<TrimPattern> trimPattern = TrimPatterns.getFromTemplate(registryAccess, templateItem)
.orElse(null);
if (trimPattern == null) return EntryIngredient.empty();
Holder.Reference<TrimMaterial> trimMaterial = TrimMaterials.getFromIngredient(registryAccess, additionItem)
.orElse(null);
if (trimMaterial == null) return EntryIngredient.empty();
ArmorTrim armorTrim = new ArmorTrim(trimMaterial, trimPattern);
Optional<ArmorTrim> trim = ArmorTrim.getTrim(registryAccess, baseItem);
if (trim.isPresent() && trim.get().hasPatternAndMaterial(trimPattern, trimMaterial)) return EntryIngredient.empty();
ItemStack newItem = baseItem.copy();
newItem.setCount(1);
if (ArmorTrim.setTrim(registryAccess, newItem, armorTrim)) {
return EntryIngredients.of(newItem);
} else return EntryIngredient.empty();
}
}
4 changes: 3 additions & 1 deletion fabric/src/main/resources/roughlyenoughitems.accessWidener
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,6 @@ accessible field net/minecraft/world/item/crafting/SmithingTrimRecipe template L
accessible field net/minecraft/world/item/crafting/SmithingTrimRecipe base Lnet/minecraft/world/item/crafting/Ingredient;
accessible field net/minecraft/world/item/crafting/SmithingTrimRecipe addition Lnet/minecraft/world/item/crafting/Ingredient;
accessible field net/minecraft/world/item/CreativeModeTab displayItemsGenerator Lnet/minecraft/world/item/CreativeModeTab$DisplayItemsGenerator;
accessible class net/minecraft/world/item/CreativeModeTab$ItemDisplayBuilder
accessible class net/minecraft/world/item/CreativeModeTab$ItemDisplayBuilder
accessible field net/minecraft/client/multiplayer/ClientLevel connection Lnet/minecraft/client/multiplayer/ClientPacketListener;
accessible field net/minecraft/client/multiplayer/MultiPlayerGameMode connection Lnet/minecraft/client/multiplayer/ClientPacketListener;
2 changes: 2 additions & 0 deletions forge/src/main/resources/META-INF/accesstransformer.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,5 @@ public-f net.minecraft.client.gui.font.CodepointMap f_283938_ # blockMap
public-f net.minecraft.client.gui.font.CodepointMap f_283773_ # blockConstructor
public net.minecraft.world.item.CreativeModeTab f_256824_ # displayItemsGenerator
public net.minecraft.world.item.CreativeModeTab$ItemDisplayBuilder
public net.minecraft.client.multiplayer.ClientLevel f_104561_ # connection
public net.minecraft.client.multiplayer.MultiPlayerGameMode f_105190_ # connection
Loading

0 comments on commit ccf3dcd

Please sign in to comment.