Skip to content

Commit

Permalink
Update readme to remove trigger caveat
Browse files Browse the repository at this point in the history
Triggers are supported now.
  • Loading branch information
shayonj committed Oct 15, 2023
1 parent 5fa6bbe commit 1345aac
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ docker run --network host -it --rm shayonj/pg-osc:latest \
--drop
```

## Caveats
## Few things to keep in mind

- Partitioned tables are not supported as of yet. Pull requests and ideas welcome.
- A primary key should exist on the table; without it, `pg-osc` will raise an exception
Expand All @@ -229,8 +229,6 @@ docker run --network host -it --rm shayonj/pg-osc:latest \
- Due to the nature of duplicating a table, there needs to be enough space on the disk to support the operation.
- Index, constraints and sequence names will be altered and lose their original naming.
- Can be fixed in future releases. Feel free to open a feature req.
- Triggers are not carried over.
- Can be fixed in future releases. Feel free to open a feature req.
- Foreign keys are dropped & re-added to referencing tables with a `NOT VALID`. A follow on `VALIDATE CONSTRAINT` is run.
- Ensures that integrity is maintained and re-introducing FKs doesn't acquire additional locks, hence the `NOT VALID`.

Expand Down

0 comments on commit 1345aac

Please sign in to comment.