Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for requirements.txt and special characters #3

Merged
merged 3 commits into from
May 19, 2024
Merged

Updates for requirements.txt and special characters #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e6042
Updated .gitignore and requirements.txt.
jimmynotjames Apr 26, 2024
1fcddd4
Updated scraper.py to refine special characters handling.
jimmynotjames Apr 26, 2024
b9ea6a8
Updates to address PR comments.
jimmynotjames Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
certifi==2020.12.5
chardet==4.0.0
idna==2.10
requests==2.25.1
urllib3==1.26.2
beautifulsoup4==4.12.3
certifi==2024.2.2
charset-normalizer==3.3.2
idna==3.7
ioutil==1.0.3
local==1.0.0
lyricsgenius==3.0.1
numpy==1.26.4
pandas==2.2.2
pyarrow==16.0.0
pyperclip==1.8.2
python-dateutil==2.9.0.post0
pytz==2024.1
requests==2.31.0
Send2Trash==1.8.3
six==1.16.0
soupsieve==2.5
speedtest-cli==2.1.3
srutil==1.0.3
tabulate==0.9.0
toml==0.10.2
tzdata==2024.1
urllib3==2.2.1
wikipedia==1.4.0
10 changes: 7 additions & 3 deletions scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def albums_to_songs_csv(songs_by_album, existing_df=None):
for song in songs_by_album[album]:
if song.title not in IGNORE_SONGS and song.title not in songs_titles:
record = {
'Title': song.title.strip('\u200b'),
'Title': song.title.replace('\u200b', ''),
'Album':
album if 'Lover (Target' not in album else 'Lover',
'Lyrics': song.lyrics,
Expand All @@ -250,7 +250,7 @@ def albums_to_songs_csv(songs_by_album, existing_df=None):
for song in songs_by_album[album]:
if song in OTHER_SONGS and song.title not in songs_titles:
record = {
'Title': song.title,
'Title': song.title.replace('\u200b', ''),
'Album': album,
'Lyrics': song.lyrics,
}
Expand Down Expand Up @@ -376,8 +376,12 @@ def clean_lyrics(lyrics: str) -> str:
lyrics = re.sub(r'\u201C|\u201D', '"', lyrics)
# Replace special unicode spaces with standard space
lyrics = re.sub(
r'[\u00A0\u1680​\u180e\u2000-\u2009\u200a​\u200b​\u202f\u205f​\u3000]',
r'[\u00A0\u1680​\u180e\u2000-\u2009\u200a​\u202f\u205f​\u3000]',
" ", lyrics)
# Replace zero-width space with empty string
lyrics = lyrics.replace('\u200b', '')
# Replace Cyrillic 'e' letters with English 'e'.
lyrics = re.sub(r'\u0435', "e", lyrics)
# Replace dashes with space and single hyphen
lyrics = re.sub(r'\u2013|\u2014', " - ", lyrics)
# Replace hyperlink text
Expand Down