fix: swallow rejected execution after shutdown

closes: fabric8io#6059
shawkins · Jun 19, 2024 · 8c57460 · 8c57460
1 parent 7074fbc
commit 8c57460
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 #### Bugs
 * Fix #6038: Support for Gradle configuration cache
+* Fix #6059: Swallow rejected execution from internal usage of the informer executor
 
 #### Improvements
 * Fix #6008: removing the optional dependency on bouncy castle

diff --git a/...lient/src/main/java/io/fabric8/kubernetes/client/informers/impl/cache/ProcessorStore.java b/...lient/src/main/java/io/fabric8/kubernetes/client/informers/impl/cache/ProcessorStore.java
@@ -113,7 +113,7 @@ public void retainAll(Set<String> nextKeys, Consumer<Executor> cacheStateComplet
       }
     });
     if (cacheStateComplete != null) {
-      cacheStateComplete.accept(this.processor::execute);
+      cacheStateComplete.accept(this.processor::executeIfPossible);
     }
   }
 

diff --git a/...ient/src/main/java/io/fabric8/kubernetes/client/informers/impl/cache/SharedProcessor.java b/...ient/src/main/java/io/fabric8/kubernetes/client/informers/impl/cache/SharedProcessor.java
@@ -175,7 +175,11 @@ public ProcessorListener<T> addProcessorListener(ResourceEventHandler<? super T>
     }
   }
 
-  public void execute(Runnable runnable) {
-    this.executor.execute(runnable);
+  public void executeIfPossible(Runnable runnable) {
+    try {
+      this.executor.execute(runnable);
+    } catch (RejectedExecutionException e) {
+      // already shutdown
+    }
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
           }
         });
         if (cacheStateComplete != null) {
-          cacheStateComplete.accept(this.processor::execute);
+          cacheStateComplete.accept(this.processor::executeIfPossible);
         }
       }
@@ Expand Down @@