fix fabric8io#4988: ensuring the previous

shawkins · Mar 22, 2023 · 231e108 · 231e108
1 parent b44cf33
commit 231e108
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 #### Bugs
 * Fix #4963: Openshift Client return 403 when use websocket
+* Fix #4988: Ensuring that previous requests are closed before retry
 
 #### Improvements
 * Fix #4477 exposing LeaderElector.release to force an elector to give up the lease

diff --git a/...rnetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/StandardHttpClient.java b/...rnetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/StandardHttpClient.java
@@ -142,6 +142,7 @@ protected <V> void retryWithExponentialBackoff(CompletableFuture<V> result,
                 LOG.debug("HTTP operation on url: {} should be retried as the response code was {}, retrying after {} millis",
                     uri, code, retryInterval);
                 retry = true;
+                cancel.accept(response);
               }
             } else if (throwable instanceof IOException) {
               LOG.debug(String.format("HTTP operation on url: %s should be retried after %d millis because of IOException",

diff --git a/...es-client-api/src/test/java/io/fabric8/kubernetes/client/http/StandardHttpClientTest.java b/...es-client-api/src/test/java/io/fabric8/kubernetes/client/http/StandardHttpClientTest.java
@@ -184,4 +184,30 @@ void testWebSocketWithLessFailuresThanRetries() throws Exception {
     assertEquals(3, client.getWsFutures().size());
   }
 
+  @Test
+  void testClosePreviousBeforeRetry() throws Exception {
+    client = client.newBuilder().tag(new RequestConfigBuilder()
+        .withRequestRetryBackoffLimit(1)
+        .withRequestRetryBackoffInterval(50).build())
+        .build();
+
+    final HttpResponse<AsyncBody> error = new TestHttpResponse<AsyncBody>().withBody(Mockito.mock(AsyncBody.class))
+        .withCode(503);
+    client.getRespFutures().add(CompletableFuture.completedFuture(error));
+    client.getRespFutures().add(CompletableFuture.completedFuture(new TestHttpResponse<AsyncBody>().withCode(200)));
+
+    CompletableFuture<HttpResponse<AsyncBody>> consumeFuture = client.consumeBytes(
+        client.newHttpRequestBuilder().uri("http://localhost").build(),
+        (value, asyncBody) -> {
+        });
+
+    Mockito.verify(error.body()).cancel();
+
+    // should ultimately succeed with the final 200
+    assertEquals(200, consumeFuture.get().code());
+
+    // only 2 requests issued
+    assertEquals(2, client.getRespFutures().size());
+  }
+
 }