-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skip option #88
Conversation
resolves sharkdp#16 and sharkdp#87
@sharkdp Should I try to make it compile on Rust 1.31 or would you rather like to increase minimum required Rust version? |
Thank you for your contribution. I bumped the min. required Rust version to 1.36 and "backported" it to this version (by matching on I also removed the |
This will also fail if the input is not a file, but a pipe, for example (this is not "reading from STDIN"):
Maybe we could catch that specific OS error and print a similar error message. Another thing: when using What about the |
I changed the error message to what you suggested. It will now also catch this specific OS error and display a proper error message. You're right about the display offset, so it will now use skip as a default, if the user does not specifiy it. It should still be possible to implement the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Since PR #75 has been open for quite some time now, I wanted to implement my own
skip
option.This PR uses the
Seek
trait as suggested.resolves #16 and #87