Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man page #151

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Add man page #151

merged 1 commit into from
Mar 27, 2022

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented Mar 22, 2022

This is written in AsciiDoc or Pandoc’s Markdown.

These can be converted by:

  • asciidoctor -b manpage doc/hexyl.1.adoc
  • pandoc -s -f markdown -t man -o doc/hexyl.1 doc/hexyl.1.md

I will fix to add a conversion process to the CI, add a troff file as well, keep only it, or other. Which one is better?

@sorairolake sorairolake force-pushed the doc/man branch 3 times, most recently from 562d0d1 to 6d62021 Compare March 23, 2022 18:03
@sharkdp
Copy link
Owner

sharkdp commented Mar 23, 2022

Awesome. Thank you very much for working on this. I would prefer the pandoc Markdown => man page way because I am familiar with this from other projects. And I don't know AsciiDoc.

@sorairolake sorairolake force-pushed the doc/man branch 4 times, most recently from 20131fd to 292455f Compare March 25, 2022 05:00
@sorairolake sorairolake marked this pull request as ready for review March 25, 2022 05:07
@sorairolake
Copy link
Contributor Author

@sharkdp OK. Added the conversion process from Pandoc's Markdown in the CI. Also, I wrote the conversion method in the README.

doc/hexyl.1.md Outdated
Comment on lines 69 to 73
Sets the block size to 1024 bytes:
: $ **hexyl \--block-size=1024**

Sets the block size to 4 kilobytes:
: $ **hexyl \--block-size=4kB**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting block size alone is not really that interesting. It's only relevant if you use it in one of the other command-line options. As in:

hexyl --block-size=1024 --length=5block …

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added one minor comment.

doc/hexyl.1.md Outdated
: $ **hexyl \--block-size=1024 \--length=5block**

Sets the block size to 4 kilobytes:
: $ **hexyl \--block-size=4kB \--length=20blocks**
Copy link
Owner

@sharkdp sharkdp Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. One more thing. blocks doesn't work, unfortunately. We should either make that work (I'd think it would be relatively easy) or change the man page here once more.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sharkdp sharkdp merged commit a23645d into sharkdp:master Mar 27, 2022
@sorairolake sorairolake deleted the doc/man branch April 7, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants