Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty file should print a warning. #107

Closed
eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #118
Closed

Empty file should print a warning. #107

eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #118
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eth-p
Copy link

eth-p commented Oct 23, 2020

Another UX issue, but I think an empty (0 byte) file should print a warning or indicator of some sorts (similarly to bat). A blank grid might be confusing when someone is under the impression that they're inspecting a non-empty file.


Note: I'm doing a class assignment regarding creating tests (from scratch) for an open-source command line program, and I chose hexyl for it. You might have a couple more of these on the way, depending on what the assignment brings to light :)

@sharkdp
Copy link
Owner

sharkdp commented Oct 24, 2020

Sounds good!

sharkdp added a commit that referenced this issue Oct 30, 2020
sharkdp added a commit that referenced this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants