Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #236

Closed
wants to merge 3 commits into from
Closed

Conversation

srijs
Copy link

@srijs srijs commented Feb 14, 2018

This patch bumps the ansi_term and ignore dependencies to the next minor version.

As a suggestion, it also includes a dependency status badge in the README.md. Let me know if you want to keep it!

@srijs
Copy link
Author

srijs commented Feb 14, 2018

Looks like we're running into this issue (again?): ogham/rust-ansi-term#31

EDIT: Depending on how ansi_term is used here, we might be able to switch to the crate that ripgrep seems to be using instead: https://crates.io/crates/termcolor. I'll look into that later today!

@sharkdp
Copy link
Owner

sharkdp commented Feb 19, 2018

Welcome, Thank you very much for your contribution!

https://deps.rs looks like a really cool and helpful project! I have added it to my release to-do list.

I'm hesitant to add a status badge for the dependency status, though. Mainly because I don't think that an "outdated" dependency is necessarily a bad thing. The Cargo.toml manifest already allows me to specify dependencies in such a way that (compatible) updates are automatically pulled in on cargo update. I might choose to use the 0.6.x versions of a specific library (including the latest patches x) because 0.7 breaks some things for me (see ansi_term). It might also be because the 0.6 version of a dependency works just fine and I don't want to risk updating to 0.7 just yet.

@srijs
Copy link
Author

srijs commented Feb 19, 2018

That's fair enough, will remove the badge for now! It was just a suggestion after all :)

What do you think about the ansi_term issue? Would you rather stick with it for now, or should I try changing to termcolor instead?

@sharkdp
Copy link
Owner

sharkdp commented Feb 20, 2018

For now, I don't see any reason to switch to another crate. If, however, ansi_term will continue to be unmaintained, we can explore other options (termcolor, colored, ..).

@sharkdp
Copy link
Owner

sharkdp commented Feb 20, 2018

Concerning the update of the ignore crate, I'm currently waiting for the next version because of BurntSushi/ripgrep#800

@srijs
Copy link
Author

srijs commented Feb 21, 2018

Fair enough, closing this!

@srijs srijs closed this Feb 21, 2018
@srijs srijs deleted the update-dependencies branch February 21, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants