Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto disable colored output for unsupported Windows shells #137

Merged
merged 2 commits into from Oct 20, 2017
Merged

Auto disable colored output for unsupported Windows shells #137

merged 2 commits into from Oct 20, 2017

Conversation

jakwings
Copy link
Contributor

Resolves #129

@sharkdp
Copy link
Owner

sharkdp commented Oct 20, 2017

Thank you very much for working on this!

I recently found this: https://github.com/ogham/rust-ansi-term/blob/090e0a383d73a43e2f80a7b466e8feeee97c4c76/src/windows.rs#L10

Do you think we could utilize this instead of pulling in all this OS-dependent code?

@jakwings
Copy link
Contributor Author

Oh yeah, very good. 😄 Rebased and tested on Win7 & Win10.

@jakwings
Copy link
Contributor Author

Oops, failed. Filed an issue to the upstream: ogham/rust-ansi-term#31

@jakwings
Copy link
Contributor Author

The previous successful patch is here: https://github.com/jakwings/fd/commit/a44e6775ba4938bc1ecbe3735101a9a50474e740

@jakwings
Copy link
Contributor Author

jakwings commented Oct 20, 2017 •
edited
Loading

While ansi-term::enable_ansi_support may take some time to stabilize, I moved jakwings/fd@a44e677 into a crate in the subdirectory "win", thus slightly reducing the OS macros used.

@sharkdp
Copy link
Owner

sharkdp commented Oct 20, 2017

Great, thank you very much!

Let's keep an eye on ogham/rust-ansi-term#31

@sharkdp sharkdp merged commit 570ea78 into sharkdp:master Oct 20, 2017
@whisperity whisperity mentioned this pull request Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakwings @sharkdp