Updated version of serde_yaml to 0.9
#2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
approved these changes
Oct 3, 2023
Enselic
reviewed
Oct 4, 2023
| @@ -23,7 +23,8 @@ fn main() { | |||
| }], | |||
| }; | |||
|
|
|||
| let bytes = serde_yaml::to_vec(&person).unwrap(); | |||
There was a problem hiding this comment.
I don't think we need to change this code? Better keep it as it is to reduce risk IMHO. Or do we have good reason to change it? I seem to be able to build with serde_yaml 0.9 without this change.
There was a problem hiding this comment.
serde_yaml::to_vec() function is deprecated in serde_yaml version 0.9
There was a problem hiding this comment.
Sorry, my bad, I missed that this was just changing example code. I can reproduce the build problem when I build this example. Thanks for fixing.
sharkdp
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #2627