Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for using cargo-rpm #189

Closed
wants to merge 1 commit into from
Closed

Conversation

cfcosta
Copy link

@cfcosta cfcosta commented Jul 14, 2018

With this, fedora/rhel/centos users can use their default package
manager to install bat, without needing cargo or rust.

With this, fedora/rhel/centos users can use their default package
manager to install bat, without needing cargo or rust.
@sharkdp
Copy link
Owner

sharkdp commented Jul 17, 2018

Great! Thank you very much!

Can we move bat.spec to a different folder (maybe assets/packaging or ci) or is .rpm required?

Also, it would be fantastic if we could add installation instructions for the mentioned distributions to the README file. I'm not familar with cargo-rpm and RPM- based package managers.

@edouardmenayde
Copy link

👍

@steven-p-walsh
Copy link

I was able to compile from source to get this to work on Fedora, but it would have been much simpler if a .rpm existed

@moosingin3space
Copy link

FYI, the Fedora community is standardizing around rust2rpm as our solution to generating RPMs from crates.

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2018

@moosingin3space What does this mean for this PR?

@moosingin3space
Copy link

@sharkdp it means that if you wish bat to be packaged in Fedora proper, rust2rpm or similar will need to be used to be compatible with Fedora packaging guidelines for Rust.

As a Fedora user and a Rust enthusiast, I think we should figure out a good solution for automatically packaging crates, possibly using COPR, but that's beyond your scope.

@sharkdp
Copy link
Owner

sharkdp commented Sep 5, 2018

@moosingin3space Thank you very much for your feedback. I'm going to close this for now and leave it up package maintainers to create RPMs/coprs/.. etc.

Hope this is fine for everyone.

@sharkdp sharkdp closed this Sep 5, 2018
@sharkdp
Copy link
Owner

sharkdp commented Sep 5, 2018

There is actually a copr by @cfcosta, but it's outdated:

https://copr.fedorainfracloud.org/coprs/cfcosta/bat/

@sharkdp sharkdp mentioned this pull request Sep 6, 2018
@moosingin3space
Copy link

I just had a look at that copr, and it seems to just distribute binaries in the SRPM, which is a big no-no in Fedora packaging policy.

For the time being, I'm using it from cargo and would recommend most users do that. When I get time, I might look into building a copr that's compatible with Fedora policy so bat can be officially packaged. It's an awesome tool!

@sharkdp
Copy link
Owner

sharkdp commented Sep 9, 2018

@moosingin3space Sounds great - Let us know!

@sharkdp sharkdp mentioned this pull request Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants