UI Revamp #5
Merged
UI Revamp #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wluberti
reviewed
Jul 11, 2018
cgi-bin/init.sh
Outdated
| @@ -10,5 +10,5 @@ fi | |||
| VOLLEY_DB=$DB VOLLEY_DEBUG=1 QUERY_STRING=action=init ./vb.cgi | |||
|
|
|||
| # temporary add an event and a guest for testing | |||
| VOLLEY_DB=$DB VOLLEY_DEBUG=1 QUERY_STRING=action=add_event\&date=test_date\&location=location\&payment_link=tbd ./vb.cgi | |||
| VOLLEY_DB=$DB VOLLEY_DEBUG=1 QUERY_STRING=action=add_event\&date="11/07/2018 19:30"\&location=Pijp\&payment_link=tbd ./vb.cgi | |||
There was a problem hiding this comment.
Ah, but this is just local test. I guess it doesn't make any difference
sharifmarat
reviewed
Jul 12, 2018
src/js/index.js
Outdated
| el: '#current-event-info', | ||
| template: ` | ||
| <p> | ||
| Most recent event: |
There was a problem hiding this comment.
Most recent event was gone already, by the way
src/js/index.js
Outdated
| </strong> | ||
| | ||
| <span v-if="start"> | ||
| <span title="Add to Calendar" class="addeventatc"> |
There was a problem hiding this comment.
The way how date is displayed changed. Before Wednesday, Jul 11th 2018 at 19:30, after 31.07.2018 19:30.
There was a problem hiding this comment.
fixed
but on the events page I'm using dd/mm/yyyy HH:mm format
index.html
Outdated
| <a class="nav-link" href="events.html">All events</a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link" href="shame.html">Shame</a> |
There was a problem hiding this comment.
This change breaks navigation (Shame is missing for example).
index.html
Outdated
| $('.addeventatc .description').text(result.message.date + ' ' + result.message.location); | ||
| $('.addeventatc .location').text(result.message.location); | ||
| <!-- js --> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/vue.min.js"></script> |
There was a problem hiding this comment.
Would vue.min.js replace jquery?
There was a problem hiding this comment.
Yup! But I'm still using $.ajax, so still need that bit. Gonna work to change it to fetch
pedroseac
force-pushed
the
master
branch
2 times, most recently
from
eaab891 to
712b029
Compare
1. Added VueJS to index page! Hooray! Currently, I'm just it using as controller for some components of the page, which makes it easier for data binding. WARNING: I moved all source files into a src folder, careful when merging TODO: use Vue routing system for SPA 2. Huge Front end refactor - Separated files around, now each page has is own js controller file - Created component for navigation bar in VueJS - Revamped UI using bulma.io (Bye Bootstrap!) - Changed datepicker from events page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VueJS on all pages, and UI Revamp.
WARNING: I moved all source files into an src folder, careful when merging
TODO: use Vue routing system for SPA
This change is