Add underscore js and bootstrap css #2
Conversation
| action: 'remove_guest', | ||
| id: guest_id | ||
| }); | ||
| if (confirm('Are you sure you want to remove ' + name + '. This is permanent!')) { |
There was a problem hiding this comment.
There was a discussion in a group regarding that. Some people suggested to type a word to actually confirm changes. Not sure if just a confirmation would be enough. Maybe use 'prompt' for removing at least?
There was a problem hiding this comment.
I guess typing isn't comfortable while using mobile device?
There was a problem hiding this comment.
They wanted to be on a very safe side to not delete by an accident
| if (i == 0) { | ||
| $('#event_date').text(result.message[i].date); | ||
| $('#event_location').text(result.message[i].location); | ||
| $('#payment_link').text('TBD'); |
There was a problem hiding this comment.
#event_date, #event_location, #payment_link are not updated after the change anymore
| @@ -4,50 +4,80 @@ | |||
| <meta name="viewport" content="width=device-width"> | |||
| <title>Let's volleyball</title> | |||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lora:400,700,400italic,700italic|Anonymous+Pro:400,700,400italic,700italic|Merriweather:400,700,300"> | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous"> | |||
| <link rel="stylesheet" href="css/main.css?v=1.0.2"> | |||
There was a problem hiding this comment.
I guess many things from main.css could be removed?
| @@ -4,50 +4,80 @@ | |||
| <meta name="viewport" content="width=device-width"> | |||
| <title>Let's volleyball</title> | |||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lora:400,700,400italic,700italic|Anonymous+Pro:400,700,400italic,700italic|Merriweather:400,700,300"> | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous"> | |||
There was a problem hiding this comment.
Is it better to use bootstrapcdn or get it locally?
There was a problem hiding this comment.
Doesn't matter. Having source outside makes less impact on the server, having it locally is more reliable, however in case with boostrap CDN it shouldn't be an issue.
| @@ -4,50 +4,80 @@ | |||
| <meta name="viewport" content="width=device-width"> | |||
| <title>Let's volleyball</title> | |||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lora:400,700,400italic,700italic|Anonymous+Pro:400,700,400italic,700italic|Merriweather:400,700,300"> | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous"> | |||
There was a problem hiding this comment.
A few comments based on this image
- Event data is not updated (important)
- Paid checkbox is on position input (less critical)
- Position iput is under a button (less critical)
No description provided.