Specify to infer spec type from file location #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you PR! I will leave this open for discussion, but I have a feeling that instead of this, we could just add the test type to each RSpec file. To me this feels like unnecessary magic, which also prevents us from arranging the specs in different directory structure. |
|
This will let us still keep the dir convention in mind. But if we decided to add type to each file. After we finished the change, we can get rid of this magic. |
|
Hi @bingxie. I'm closing this now as we have not yet upgraded to rspec3. I prefer to force an explicit choice about this at upgrade time instead. |
|
That's ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of the warning for the coming rspec3.