Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GPID (openrtb endpoint) #1110

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

epechuzal
Copy link

Sister PR to #1107, this time for openRTB endpoint.

From a talk with STX they want the param to be in imp.ext.gpid, so I added it there.

@epechuzal epechuzal requested a review from maphe June 23, 2021 17:36
@epechuzal epechuzal self-assigned this Jun 23, 2021
@epechuzal epechuzal changed the base branch from master to mp/177858674/open-rtb June 23, 2021 17:37
modules/sharethroughBidAdapter.js Outdated Show resolved Hide resolved
@epechuzal epechuzal merged commit 12acb1a into mp/177858674/open-rtb Jun 23, 2021
@epechuzal epechuzal deleted the ep/PGE-178206244/gpid-ortb branch June 23, 2021 19:06
@sjfields100
Copy link

Hey guys, looks like this update may have broken sharethrough on our site-- it doesn't work above prebid v 5.13. Did any required configurations change for sharethrough or is it just the pkey that is still required? It works below v 5.13.

Here is a test page:
https://wishlist.indy100.com/37-gadgets-that-make-cleaning-10x-easier/?test=cleanup&pbjs_debug=true&5.13.0

Sceenshot of errors in network tab of DOM:
Screen Shot 2021-09-17 at 4 20 12 PM

@epechuzal
Copy link
Author

epechuzal commented Sep 20, 2021

Hey guys, looks like this update may have broken sharethrough on our site-- it doesn't work above prebid v 5.13. Did any required configurations change for sharethrough or is it just the pkey that is still required? It works below v 5.13.

Required configuration should not have changed. I do not get HTTP 400 responses when I visit your test page either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants