Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no type handling for linter like Pylance #64

Open
Writtic opened this issue Feb 26, 2022 · 1 comment
Open

There is no type handling for linter like Pylance #64

Writtic opened this issue Feb 26, 2022 · 1 comment
Assignees
@Writtic
Labels
enhancement New feature or request

Comments

@Writtic
Copy link
Contributor

Writtic commented Feb 26, 2022

Description

Pylance와 같이 Pyright로 엄밀한 타이핑 검사를 하는 Linter를 사용할 때, pyupbit는 엄청나게 많은 밑줄을 유발합니다.

따라서 전반적으로 pyupbit에 typing 처리가 된다면, 해당 패키지로 개발하는 경험이 한층 더 개선될 것 같습니다.
@Writtic Writtic mentioned this issue Feb 26, 2022
Merged
@mr-yoo mr-yoo self-assigned this Feb 27, 2022
@mr-yoo mr-yoo added the enhancement New feature or request label Feb 27, 2022
@Writtic Writtic mentioned this issue Feb 27, 2022
Merged
@Writtic
Copy link
Contributor Author

Writtic commented Feb 27, 2022

위 PR #67 까지만 일단 작업하고, 이후 typing 작업은 3/1 변경사항이 적용된 이후 이어나갈 계획입니다.

Reference: #58

@Writtic Writtic changed the title There is no typing handling for linter like Pylance There is no type handling for linter like Pylance Mar 4, 2022
@mr-yoo mr-yoo assigned Writtic and unassigned mr-yoo Mar 13, 2022
mr-yoo added a commit that referenced this issue May 4, 2022
@mr-yoo
pylint warning 제거 (#64)
b4db566 
- 80라인 이상의 코드 정리
- is와 == 연산자의 잘못된 사용 정리
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Writtic Writtic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Writtic @mr-yoo