Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-192-monitor-client-github-workflow #3

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

chrypnotoad
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jun 10, 2024

SYS-192 monitor-client github workflow

https://github.com/shardeum/x-monitor-client

  • Create a PR with this workflow script .github/workflows/ci.yml
  • adjust the npm scripts in package.json needed. The might be missing. In the case of npm test if it if has the default echo and error make sure it doesn't fail
    • scripts used in shared workflow:
      • npm run lint
      • npm run format-check
      • npm run build
      • npm test

.github/workflows/ci.yml

name: Node CI Workflow
# The parameters are defaulted at the org level but can be overridden on the repository.
on:
  push:
    branches:
      - dev
      - main
  pull_request:
    branches:
      - dev
      - main
  workflow_dispatch:
    inputs:
      workflowBranch:
        description: 'Branch of the reusable workflow. Defaults to main, select dev for testing only.'
        required: true
        default: 'main'
        type: choice
        options:
          - dev
          - main
jobs:
  ci-dev:
    if: ${{ github.event.inputs.workflowBranch == 'dev' }}
    uses: shardeum/github-automation/.github/workflows/node-ci-shared.ymldev

  ci-main:
    if: ${{ github.event.inputs.workflowBranch == 'main' || !github.event.inputs.workflowBranch }}
    uses: shardeum/github-automation/.github/workflows/node-ci-shared.ymlmain

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]

2

🧪 Relevant tests

No

🔒 Security concerns

No

⚡ Key issues to review

None

@muni-corn muni-corn force-pushed the sys-192-monitor-client-github-workflow branch from fd3ed08 to 6794445 Compare July 9, 2024 22:34
@muni-corn muni-corn merged commit b20ea50 into dev Jul 9, 2024
2 checks passed
@muni-corn muni-corn deleted the sys-192-monitor-client-github-workflow branch July 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants