SHARD-1058: Add per-IP connection limit to WebSocket server #97
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S0naliThakur
requested review from
aniketdivekar,
jintukumardas,
mgthuramoemyint and
abdulazeem-tk4vr
| @@ -122,6 +123,7 @@ export const CONFIG: Config = { | |||
| maxConnections: Number(process.env.WS_MAX_CONNECTIONS) || 1000, | |||
| maxSubscriptionsPerSocket: Number(process.env.WS_MAX_SUBSCRIPTIONS_PER_SOCKET) || 50, | |||
| connectionTimeoutMs: Number(process.env.WS_CONNECTION_TIMEOUT_MS) || 24 * 60 * 60 * 1000, // 1 day in ms | |||
| maxConnectionsPerIP: Number(process.env.WS_MAX_CONNECTIONS_PER_IP) || 50, | |||
There was a problem hiding this comment.
as discussed, let's change it to 2 or 3
| @@ -23,15 +23,30 @@ interface Request { | |||
|
|
|||
| // Add connection counter | |||
| let activeConnections = 0 | |||
| const connectionsByIP = new Map<string, number>() | |||
There was a problem hiding this comment.
maintain sockets itself instead of count. This will help us identify disconnected sockets which can be cleaned up upon request if need be to allow requested connection
| // Check max connections limit | ||
| if (activeConnections >= CONFIG.websocket.maxConnections) { | ||
| socket.close(1003, 'Server busy. Please try again later.') | ||
| export const onConnection = async (socket: WebSocket.WebSocket, req: any): Promise<void> => { |
There was a problem hiding this comment.
can we use specific type for req instead of any?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1058
Summary:
maxConnectionsPerIPto limit the number of concurrent WebSocket connections from a single IP address.onConnectionfunction to check the number of active connections per IP and close the socket if the limit is reached.