SHARD-1058: limits on socket connections, subscriptions per socket, connection timeout +fixes #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…socket, and one-day timeout for connections
S0naliThakur
requested review from
aniketdivekar,
BelfordZ,
jintukumardas and
abdulazeem-tk4vr
abdulazeem-tk4vr
approved these changes
Dec 4, 2024
aniketdivekar
approved these changes
Dec 4, 2024
BelfordZ
reviewed
Dec 5, 2024
BelfordZ
reviewed
Dec 5, 2024
| @@ -0,0 +1,226 @@ | |||
| import WebSocket from 'ws' | |||
BelfordZ
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
great work.
Further improvements: in the timeout, lets reduce the timer, and make it check if the socket is 'active' aka lets track the usage of the socket, and only drop the ones that are inactive, until we hit a hard limit.
we can do that next time though. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1058/
Summary:
This PR introduces the following changes: