Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARD-893: Clear filtersMap when it reaches maximum entries allowed #85

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

abdulazeem-tk4vr
Copy link
Member

@abdulazeem-tk4vr abdulazeem-tk4vr commented Nov 7, 2024

The code changes in api.ts introduce a check to clear the filtersMap when it reaches the maximum number of entries allowed, as specified by the maxEntriesAllowed configuration value. This ensures that the filtersMap does not exceed the allowed size and prevents potential performance issues and DoS attacks

Linear : https://linear.app/shm/issue/SHARD-893/[bug-bounty]-35534-json-rpc-server-remote-crash

@abdulazeem-tk4vr abdulazeem-tk4vr self-assigned this Nov 7, 2024
@abdulazeem-tk4vr abdulazeem-tk4vr changed the title SHARD-1062 : Clear filtersMap when it reaches maximum entries allowed SHARD-893: Clear filtersMap when it reaches maximum entries allowed Nov 7, 2024
@jintukumardas jintukumardas changed the title SHARD-893: Clear filtersMap when it reaches maximum entries allowed [DRAFT] SHARD-893: Clear filtersMap when it reaches maximum entries allowed Nov 11, 2024
aniketdivekar
aniketdivekar previously approved these changes Nov 13, 2024
aniketdivekar
aniketdivekar previously approved these changes Nov 21, 2024
The code changes in `api.ts` introduce a check to clear the `filtersMap` when it reaches the maximum number of entries allowed, as specified by the `maxEntriesAllowed` configuration value. This ensures that the `filtersMap` does not exceed the allowed size and prevents potential performance issues and DoS attacks
@aniketdivekar aniketdivekar changed the title [DRAFT] SHARD-893: Clear filtersMap when it reaches maximum entries allowed SHARD-893: Clear filtersMap when it reaches maximum entries allowed Nov 21, 2024
@urnotsam urnotsam merged commit f94b6c7 into dev Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants