Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLUE-231: Added socket timeout for open connections #58

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

aniketdivekar
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Hardcoded Value
The timeout value for the socket is hardcoded to 20000 milliseconds. Consider making this configurable to allow for flexibility in different environments.

jairajdev
jairajdev previously approved these changes Sep 3, 2024
jairajdev
jairajdev previously approved these changes Sep 4, 2024
S0naliThakur and others added 2 commits September 3, 2024 23:45
Update methodWhitelist.ts

update methodWhitelist status code
refactor methodWhitelist middleware logic
added keep alive config on connection
@mhanson-github mhanson-github merged commit 30a0027 into dev Sep 4, 2024
7 checks passed
@mhanson-github mhanson-github deleted the BLUE-231 branch September 7, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants