Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-331: Update _REASONS map with new signature and gas reasons #51

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

muni-corn
Copy link
Contributor

Copy link

github-actions bot commented Aug 5, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Redundant Code
The new entries 'Transaction is not signed' and 'Transaction signature is invalid' might be redundant or overlapping with the previous 'Invalid signature' entry. Consider consolidating these to avoid potential confusion and maintain code simplicity.

@chrypnotoad chrypnotoad requested a review from a team August 6, 2024 15:37
mssabr01
mssabr01 previously approved these changes Aug 6, 2024
mssabr01
mssabr01 previously approved these changes Aug 7, 2024
@mhanson-github mhanson-github merged commit d390342 into dev Aug 21, 2024
6 of 7 checks passed
@mhanson-github mhanson-github deleted the sys-331 branch August 30, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants