GREEN-42 add gasUsed and transaction root for returned block data #15
Conversation
package.json
Outdated
| @@ -36,6 +36,7 @@ | |||
| "got": "11.8.6", | |||
| "jayson": "3.6.5", | |||
| "jsonwebtoken": "9.0.0", | |||
| "merkle-patricia-tree": "^4.2.4", | |||
There was a problem hiding this comment.
Remove carat in version.
src/external/Collector.ts
Outdated
| // Now we have the block gas used then return it to the RPC method | ||
| resultBlock.gasUsed = blockGasUsed | ||
| // Start to calculate the transaction root fot this block | ||
| resultBlock.transactionsRoot = await this.calculateTransactionRoot(readableBlock.tranactions) |
There was a problem hiding this comment.
This appears to be misspelled. Am not sure how this could have worked.
There was a problem hiding this comment.
build does not compile
~/shardus/npm-release/json-rpc-server$ npm run compile
[email protected] compile
tsc -p .
src/external/Collector.ts:20:27 - error TS2307: Cannot find module 'ethers' or its corresponding type declarations.
20 import { BigNumber } from 'ethers'
~~~~~~~~
Found 1 error.
src/external/Collector.ts
Outdated
|
|
||
| import { BaseTrie } from 'merkle-patricia-tree' | ||
| import RLP from 'rlp' | ||
| import { BigNumber } from 'ethers' |
There was a problem hiding this comment.
Looks like the import lib has to be @ethersproject/bignumber
src/external/Collector.ts
Outdated
| @@ -245,6 +247,19 @@ class Collector extends BaseExternal { | |||
| return await this.inner_getBlock(blockSearchValue, blockSearchType, details) | |||
| } | |||
|
|
|||
| async calculateTransactionRoot(txns: String[]): Promise<String> { | |||
There was a problem hiding this comment.
I think the correct type has to be string
|
By changing the command npm ci to npm i in both smoke tests 10+10 and 25+5, these two tests were passed 25+5: https://devs-work.shardeum.org/job/Testing/job/Smoke/job/work_in_progress/job/wip_green_25_plus_5/2/ |
jairajdev
force-pushed
the
GREEN-42-Fix-incorrect-returned-block-data
branch
from
e003c85 to
f220900
Compare
mhanson-github
deleted the
GREEN-42-Fix-incorrect-returned-block-data
branch
Add block gasUsed and transaction root to the returned block data