tv-casting-app: fix TargetVideoPlayerInfo mem corruption

[sharadb-amazon]

Problem

The IPAddress and MACAddress fields (in the TargetVideoPlayerInfo), required for the WakeOnLAN implementation, were sometimes getting corrupted when the VerifyOrEstablishConnectionTask() API is called. This was because the VerifyOrEstablishConnection() API gets a reference to the targetVideoPlayerInfo that is created on the stack by the caller. If we copy the input param targetVideoPlayerInfo to the mActiveTargetVideoPlayerInfo, the underlying memory for the IPAddress and MACAddress may get deallocated as the original targetVideoPlayerInfo goes out of scope of the caller.

Solution

Find the index of the targetVideoPlayerInfo in the mCachedTargetVideoPlayerInfo array that is held in the CastingServer class as a data member. Then copy the cached equivalent of the targetVideoPlayerInfo to mActiveTargetVideoPlayerInfo. This way the memory locations the mActiveTargetVideoPlayerInfo stays valid during a connection attempt, as the mCachedTargetVideoPlayerInfo[] is a CastingServer class data member.

Testing

Tested using the android tv-casting-app running against the Linux tv-app and checked that the IP Address and MAC Address fields now stay valid.

[github-actions]

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

[github-actions]

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

[github-actions]

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>