Skip to content

Commit

Permalink
Addressing feedback from andy31415@
Browse files Browse the repository at this point in the history
  • Loading branch information
sharadb-amazon committed Apr 4, 2024
1 parent 364efec commit d82d2b3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion examples/tv-casting-app/linux/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ CHIP_ERROR ProcessClusterCommand(int argc, char ** argv)

int main(int argc, char * argv[])
{
ChipLogProgress(AppServer, "chip_casting_simplified = 0");
ChipLogProgress(AppServer, "chip_casting_simplified = 0"); // this file is built/run only if chip_casting_simplified = 0
VerifyOrDie(CHIP_NO_ERROR == chip::Platform::MemoryInit());
VerifyOrDie(CHIP_NO_ERROR == chip::DeviceLayer::PlatformMgr().InitChipStack());

Expand Down
2 changes: 1 addition & 1 deletion examples/tv-casting-app/linux/simple-app.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class CommonCaseDeviceServerInitParamsProvider : public ServerInitParamsProvider

int main(int argc, char * argv[])
{
ChipLogProgress(AppServer, "chip_casting_simplified = 1");
ChipLogProgress(AppServer, "chip_casting_simplified = 1"); // this file is built/run only if chip_casting_simplified = 1
// Create AppParameters that need to be passed to CastingApp.Initialize()
AppParameters appParameters;
RotatingDeviceIdUniqueIdProvider rotatingDeviceIdUniqueIdProvider;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@
#define CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_SUBJECTS_PER_ENTRY 20
#define CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_ENTRIES_PER_FABRIC 20

// For casting, we need to allow for more binding table entries
// For casting, we need to allow for more binding table entries because the Casting App can connect to many Matter Casting Players,
// each with many Content Apps. Each Casting Player will set 1 binding per endpoint on it. ACasting Player will have 1 endpoint for
// every Matter Content App installed on it + 1 endpoint representing the Casting Player + 1 endpoint representing a speaker.
#define MATTER_BINDING_TABLE_SIZE 64

// Enable some test-only interaction model APIs.
Expand Down

0 comments on commit d82d2b3

Please sign in to comment.