Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BLE support for RS9116 #54

Open
wants to merge 34 commits into
base: feature/rs911x_ble_implemenation
Choose a base branch
from

Conversation

shgutte
Copy link
Collaborator

@shgutte shgutte commented Nov 8, 2022

Added the flow to add support the ble for rs9116 implementation

Copy link

@rosahay-silabs rosahay-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify license headers and briefs on all files
  • Remove commented unused code
  • Restructure init functions to maintain different configuration builds.
  • Proper log messages
  • Remove unneeded files
  • Remove updates on the third_party repos that are not silabs

build/config/compiler/BUILD.gn Outdated Show resolved Hide resolved
examples/lighting-app/efr32/src/main.cpp Outdated Show resolved Hide resolved
examples/platform/efr32/rs911x/rs911x.gni Outdated Show resolved Hide resolved
examples/platform/efr32/rs911x/rsi_if.c Outdated Show resolved Hide resolved
src/platform/EFR32/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/EFR32/RS911x/BLEManagerImpl.h Outdated Show resolved Hide resolved
src/platform/EFR32/RS911x/BLEManagerImpl.h Outdated Show resolved Hide resolved
* Silicon Labs Module starts advertising and with BLE Provisioning the Access Point
* details are fetched.
* Silicon Labs device is configured as a WiFi station and connects to an Access Point.
=================================================================================*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief does not make sense here.

src/platform/EFR32/RS911x/wfx_sl_ble_init.c Outdated Show resolved Hide resolved
/* Structure that will hold the TCB of the wfxRsi Task being created. */
StaticTask_t driverRsiTaskBuffer;

int32_t wfx_sl_module_init(void)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function should be moved to common place and wrapped with proper macros to enable/disable features on this board.

@github-actions github-actions bot removed the lwip label Nov 10, 2022
@@ -32,7 +32,7 @@
#include "event_groups.h"
#include "task.h"

#include "wfx_sl_ble_init.h"
//#include <wfx_sl_module_init.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove if not needed

src/platform/EFR32/rs911x/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
build/config/compiler/BUILD.gn Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gn label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants