Mark compound assignments as not binding elements #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let node = operator.type === TokenType.ASSIGN | ||
| ? { type: "AssignmentExpression", binding: expr, expression: rhs } | ||
| : { type: "CompoundAssignmentExpression", binding: expr, operator: operator.type.name, expression: rhs }; | ||
| if (operator.type !== TokenType.ASSIGN) { |
There was a problem hiding this comment.
I don't like doing this test twice in a row. Let's combine these two statements.
bakkot
force-pushed
the
compound-assign-fix
branch
from
6569ba4
to
68852bc
Compare
michaelficarra
added a commit
that referenced
this pull request
Feb 23, 2016
Mark compound assignments as not binding elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189 and #255.
Note that the two additional tests in
update-expression.jswere actually fixed by a30696c, but they're added here as part of closing #189.As this PR closes all remaining known bugs except #130 and #168, it's probably time for a patch version bump + publish.