Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with numpy 2.1 dev to cast GeometryType to int as ufunc input #2099

Merged

Conversation

jorisvandenbossche
Copy link
Member

Fixes #2098

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10262405824

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on np-ufunc-gometrytype-int at 88.158%

Totals Coverage Status
Change from base Build 10262394920: 88.2%
Covered Lines: 2628
Relevant Lines: 2981

💛 - Coveralls

Copy link
Member

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is the correct cast type, and is consistent with other ufunc enums.

After merge, this should be cherry-picked into maint-2.0 to resolve CI failures too.

@jorisvandenbossche jorisvandenbossche merged commit 775f779 into shapely:main Aug 6, 2024
25 checks passed
@jorisvandenbossche jorisvandenbossche deleted the np-ufunc-gometrytype-int branch August 6, 2024 08:01
@jorisvandenbossche jorisvandenbossche added this to the 2.0.6 milestone Aug 6, 2024
mwtoews pushed a commit that referenced this pull request Aug 15, 2024
@EwoutH
Copy link
Contributor

EwoutH commented Aug 18, 2024

It's a bit weird that NumPy 2.1 breaks stuff right, as a minor release?

Anyway, since NumPy could release 2.1 at any moment, could a new release be tagged, either to Shapely 2.0.x with a backport or Shapely 2.1?

@EwoutH
Copy link
Contributor

EwoutH commented Aug 18, 2024

If all else is not feasible, could we set NumPy to <2.1 on the Shapely 2.0 branch and sprint a release out?

"numpy>=1.14,<3",

@orthorhombic
Copy link

NumPy just released 2.1.0, and I noticed this impacting my code. It would be nice to get a release out.

@EwoutH - Impressive that you guessed "NumPy could release 2.1 at any moment" <4 hours before they released it.

@EwoutH
Copy link
Contributor

EwoutH commented Aug 19, 2024

What’s the strangest is that @jorisvandenbossche added this to the 2.0.6 milestone over two weeks ago, but 2.0.6 was never released.

@axelande
Copy link

Will 2.0.6 be released or what is missing from that being released?

@jorisvandenbossche
Copy link
Member Author

What’s the strangest is that @jorisvandenbossche added this to the 2.0.6 milestone over two weeks ago, but 2.0.6 was never released.

That's because milestones are used for future releases ;)

We were planning to cut a 2.0.6 release if needed (if numpy 2.1 was released before a next shapely release), which is the case now, so will try to do that the coming hours.

@jorisvandenbossche
Copy link
Member Author

Shapely 2.0.6 is released (it's on pypi, conda-forge can still take a few hours)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufunc 'create_collection' not supported for the input types
6 participants