fix: segmentation faults on MacOS with lightgbm tests (with newer libomp versions) #3093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description of the changes proposed in this pull request:
Fix the segmentation fault issue arising from lightgbm x
libomp
version on MacOS.Read #3092 for the diagnostics / reproducible example.
This isn't a new problem (been an issue since 2021 it seems, cf. microsoft/LightGBM#4229 and autogluon/autogluon#1442).
So not quite sure why this error is only popping up now, but it's probably triggered by the new 4.0 release of lightgbm a couple days ago.
If you read the threads above, the canonical solution is to downgrade the
libomp
version to < 12. But I don't think that is necessary anymore, sincelightgbm
distributes its ownlibomp
to the best of my understanding, which is why the bug only occurs if youimport torch, lightgbm
, but not whenimport lightgbm, torch
.So I'm proposing a different solution, which is to import
lightgbm
as early as possible in our test suite, and it seems to work.Checklist
CHANGELOG.md
(if changes will affect users)