Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Fix for OSS issues and a couple of bug fixes #739

Closed
wants to merge 1 commit into from

Conversation

dan-dr
Copy link

@dan-dr dan-dr commented Dec 17, 2018

  • Add custom setting codeCliPath for OSS users
  • Add usage of the documented useCliBaseInstallation
  • Fix removing and adding extensions without cli to use lowercase pacakage names

Short description of what this resolves:

Fixes issue where the extensions didn't sync under the OSS variant of VS Code.
The problem seemed to stem from the inability of the extension to find the cli of VS Code.

Changes proposed in this pull request:

  • Let users set the cli path of VS Code in the extension local settings
  • Let users disable installation using the useCliBaseInstallation settings - which was documented but not used anywhere - which also fixes OSS issues (depending on the next listed change)
  • Force installation and deletion of extensions without cli to use lowercase folder paths for the extension paths, otherwise VS Code might not recognize the extension is installed, or the extension my not be removed if installed manually.

Fixes: #668

How Has This Been Tested?

Ran this on my local dev machine (Solus Linux) where downloading and removing extensions didn't work at all using the OSS variant of VS Code.

Performed multiple installs, uninstalls, uploading and downloading of settings.
Without manually editing the new custom settings, the extension behaves exactly the same, so users who do not have issues will continue normally.

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and Github Wiki.
  • I have updated the documentation and Wiki accordingly.
  • Test with existing Non OSS versions.

* Add usage of the documented "useCliBaseInstallation"
* Fix removing and adding extensions without cli to use lowercase pacakage names
@shanalikhan shanalikhan added this to the v3.2.5 milestone Dec 18, 2018
@shanalikhan
Copy link
Owner

shanalikhan commented Dec 18, 2018

Ran this on my local dev machine (Solus Linux) where downloading and removing extensions didn't work at all using the OSS variant of VS Code.

As you have tested this in your machine with OSS version of code.

Can you test it also for Standard, and portable version for NON OSS code so we make sure it doesnt break on the existing versions of code?

@dan-dr
Copy link
Author

dan-dr commented Dec 18, 2018

Sure. I'll try to test those on Windows soon. If someone else wants to chip that'll help.

@tristan957
Copy link

@dan-dr have you tested on Windows yet?

@knobhead
Copy link

knobhead commented Dec 23, 2018

this surely would be a nice christmas present :-) 🎄

@shanalikhan
Copy link
Owner

Yes, I will release new version. Once its been tested for Non OSS versions of code ( to make sure it doesnt break existing) also like tested for OSS versions.

@shanalikhan shanalikhan changed the title Fix for OSS issues and a couple of bug fixes WIP : Fix for OSS issues and a couple of bug fixes Jan 3, 2019
@shanalikhan shanalikhan removed this from the v3.2.5 milestone Feb 11, 2019
@tristan957
Copy link

What is the status of this?

@jakkn jakkn mentioned this pull request Feb 16, 2019
@ptMuta
Copy link

ptMuta commented Mar 8, 2019

Soo.. Abandoned? :/

@shanalikhan
Copy link
Owner

Closing this PR.
Reason : #668 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants