-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Fix for OSS issues and a couple of bug fixes #739
Conversation
* Add usage of the documented "useCliBaseInstallation" * Fix removing and adding extensions without cli to use lowercase pacakage names
As you have tested this in your machine with OSS version of code. Can you test it also for Standard, and portable version for NON OSS code so we make sure it doesnt break on the existing versions of code? |
Sure. I'll try to test those on Windows soon. If someone else wants to chip that'll help. |
@dan-dr have you tested on Windows yet? |
this surely would be a nice christmas present :-) 🎄 |
Yes, I will release new version. Once its been tested for Non OSS versions of code ( to make sure it doesnt break existing) also like tested for OSS versions. |
What is the status of this? |
Soo.. Abandoned? :/ |
Closing this PR. |
codeCliPath
for OSS usersuseCliBaseInstallation
Short description of what this resolves:
Fixes issue where the extensions didn't sync under the OSS variant of VS Code.
The problem seemed to stem from the inability of the extension to find the cli of VS Code.
Changes proposed in this pull request:
useCliBaseInstallation
settings - which was documented but not used anywhere - which also fixes OSS issues (depending on the next listed change)Fixes: #668
How Has This Been Tested?
Ran this on my local dev machine (Solus Linux) where downloading and removing extensions didn't work at all using the OSS variant of VS Code.
Performed multiple installs, uninstalls, uploading and downloading of settings.
Without manually editing the new custom settings, the extension behaves exactly the same, so users who do not have issues will continue normally.
Checklist: