Feature request : add a login(account) option to sync all settings using account #506

kanatkubash · 2018-03-05T04:33:58Z

It would very great if you have added something like account or log in, so that you can log in to vs code and have all settings synced across all logged in vs code instances - so you don't have to remember gist id

By @shanalikhan , here is the initial page UI.

A page will be opened inside code [like Git Lens extension] initially when the user does not have anything configured.
Page contains Settings Sync information and some good UI
A Button should be present with a current option as "Github"
When user click button, Username and password and Gist ID fields should be shown to the user to fill them.
On entering details user should click on submit button.
On click event should get those values and just close that tab.

Join our slack channel for discussion directly with me while you develop so i can assist you.

IssueHunt Summary

arnohovhannisyan has been rewarded.

Backers (Total: $318.00)

boostio ($60.00)
loadbalance-sudachi-kun ($256.00)
aashutoshrathi ($2.00)

Submitted pull Requests

#876 [Ready for Review] GUI - Login with GitHub

Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

shanalikhan · 2018-03-22T16:22:08Z

Low priority.
PR is welcome for it.

IssueHuntBot · 2018-09-14T04:51:28Z

@BoostIO funded this issue with $60. Visit this issue on Issuehunt

IssueHuntBot · 2018-09-17T03:01:48Z

@loadbalance-sudachi-kun funded this issue with $256. Visit this issue on Issuehunt

shanalikhan · 2018-09-19T16:42:55Z

This issue is available in bounty program, fix and earn the money 😄

IssueHuntBot · 2018-09-20T07:08:44Z

@zhangzhishan has started working. Visit this issue on Issuehunt

shanalikhan · 2018-10-11T13:56:59Z

@zhangzhishan is there any progress? I can assist you if you have started working on it.
You can send a PR, and we can discuss over there.

zhangzhishan · 2018-10-13T06:00:47Z

@zhangzhishan is there any progress? I can assist you if you have started working on it.

I have a design and working on the account back-end work.

shanalikhan · 2018-10-19T17:03:03Z

Its been a month and its the paid one.
It would be great, if you can send a PR for (work in progress) so i can see the changes while you are making progress.

shanalikhan · 2018-10-30T09:25:52Z

This issue is opened again for Bounty.

Amount funded
$316

PicchiKevin · 2019-01-31T22:42:24Z

What about connecting with a github account ?
Is this what you mean ?

IssueHuntBot · 2019-03-18T10:04:49Z

@aashutoshrathi has funded $2.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

shanalikhan · 2019-03-18T10:34:42Z

@PicchiKevin

It means, you currently Settings Sync require github account, therefore github Button to connect is required in order to enter the required details

aashutoshrathi · 2019-03-18T13:18:46Z

@shanalikhan You mean instead of asking access token we have to implement Auth using GUI right?

shanalikhan · 2019-03-18T16:43:49Z

Yes.
Auth using GUI alongwith GUI that should have all the things present for the Settings Sync.
Example is the page for Git Lens that shows up when you install that extension.

janat08 · 2019-03-26T17:42:56Z

For this to be secure it will need backend. Are you okay with this, as hypothetically one day it will crash or something, or be overloaded and you're on the hook (ill use zeit)?

kanatkubash · 2019-03-26T17:49:47Z

@janat08 Maybe open up a browser page for github oauth consent screen, where callback is set to local server spawned within extension, and on access grant, it just picks up access token and stores it ?

janat08 · 2019-03-26T17:54:48Z

I suppose that makes sense.

janat08 · 2019-03-26T23:45:44Z

Well I was reffering to secret code of oauth application, which I assume would have to be shared in the extensions if done without the backend?

kanatkubash · 2019-03-29T06:34:11Z

@janat08 Yeah, I missed this point. But I believe there are no rogue extensions , that will try to use the token. Also tokens scope is limited to gists. @shanalikhan What do you think ?

qti3e · 2019-06-30T17:41:09Z

Also, it's possible to use Firebase... I would be happy to work on this issue :) but I don't know the current state.

janat08 · 2019-06-30T17:47:57Z

Its like totally done, they decided to do some extra prep work before merge.

* Updated to task api 2.0.0 and fixed tests * Set "extensionKind": "ui" to support remote development #61 Fixes #870. See that issue for details * Clean up previous commits into one * #800 #515 #854 * Utilized pragmaUtil Functions for kb.json file * Typo fix * Added universalKeybindings setting * chore(package): update @types/node to version 12.0.0 (#873) * Cleaned up toggling commented settings (#877) * Cleaned up toggling commented settings * Updated to include fix by @ioprotium * Fix warning with webpack * Update UI * Change height to max-height * Add image locally and move it to the top * Added documentation for tests in CONTRIBUTING.md (#881) * fix(package): update fs-extra to version 8.0.0 (#882) * chore(package): update @types/fs-extra to version 7.0.0 (#885) * chore(package): update @types/node to version 12.0.1 (#883) * fix(package): update fs-extra to version 8.0.1 (#884) * Update UI to fit guidelines * chore(package): update @types/node to version 12.0.2 (#887) * Improve UI and functionality * Match BG of theme and properly contrast text * Fix issues with themes * Fix image not showing up with light theme * Fix issues with contrast * Fix issue with VS Code's WebView * Update UI and functionality * Fix potential issue with light themes * Fix issues with theme on modal * Refactor * Add new (but experimental) localizations (#898) * chore(package): update clean-webpack-plugin to version 3.0.0 (#899) * #891 * Update settings page after a reset * Improve code * fix(clean-webpack-plugin): (#901) clean-webpack-plugin was recently updated, and it had breaking changes. * chore(package): update @types/node to version 12.0.3 (#897) * #668 * fix(OSS): enums.ts ---- Allow for setting os type with less code environmentPath.ts ---- Find code folder and extensions folder more efficiently Get OS type more efficiently settings.ts ---- Ignore all state files sync.ts ---- Adapt for changes in pluginService pluginService.ts ---- Use vscode command to install extensions Clean up code and simplify names * Install extensions in order * Comment legacy code instead of deleting it * Fix extension install * Fix issue with extensions always being deleted * Get code path more efficiently * Make sure to escape spaces in cli path * Fix issues with portable builds * Support Windows and certain editions * Improve method for finding extension folder * Start using API for installation * Prepare for new API command * Get ready for new API command * Fix issue with installation * Commit requested changes * #668 * Format pluginService.ts (#906) * #668 * Throw error * Try to fix issues with getting missing * chore(package): update @types/node to version 12.0.7 (#904) * chore(package): update @types/node to version 12.0.8 (#908) * #668 * #668 * #668 * #839 * Support multiple instances * Completely switch to state * Update to work properly * Move setting classes to their own models * Update service names * Only auto upload using focused window * Resolve merge conflicts * #886 * Resolve locale properly * Clean constructor * Use state instead of passing in argument * Update to be compatible with v3.3.0 changes * Fix readme * Fix package.json * Add new settings * Increase contrast * Update package.nls.*.json ---- Add localizations for setting names and placeholders. github.oauth.service.ts ---- Handle errors in a more user-facing way Support GitHub enterprise Show message to user after success webview.service.ts ---- Use new localizations for names and placeholders * Bug fix and upload images * Add support for commits to master (release notes) * Fix issue * Fix another issue with release notes * Update release note template * Update release notes * Don't open gist selection if there aren't any gists * Allow user to view gist * Revert accidental change * Support public gist * Add css, js, and fonts to repo * Improve font injection * Revert accidental change

* Fix webpack build process * Only ignore warning from express

* Add button to download public gist * Download after getting public gist

shanalikhan · 2019-07-15T10:39:09Z

v3.4.0 is released containing this feature by @arnohovhannisyan
Update this extension. Let us know what you think and where we can improve the UI.

issuehunt-oss · 2019-07-18T10:59:50Z

@shanalikhan has rewarded $222.60 to @arnohovhannisyan. See it on IssueHunt

💰 Total deposit: $318.00
🎉 Repository reward(20%): $63.60
🔧 Service fee(10%): $31.80

shanalikhan · 2019-07-18T11:01:35Z

As it was released on v3.4.0
Closing this ticket.

shanalikhan added feature-request 💡 PR-Welcome ✨ labels Mar 22, 2018

shanalikhan added the bounty label Sep 19, 2018

shanalikhan added the hacktoberfest label Oct 2, 2018

shanalikhan added this to the Backlog milestone Oct 11, 2018

shanalikhan removed the hacktoberfest label Oct 19, 2018

zhangzhishan mentioned this issue Oct 22, 2018

WIP : #506 #691

Closed

This was referenced Mar 31, 2019

Overhaul extension (WIP) #814

Closed

Login with GitHub (WIP) #825

Closed

auxves mentioned this issue Apr 16, 2019

[WIP] GUI - Login with GitHub #846

Closed

8 tasks

auxves mentioned this issue May 4, 2019

[Ready for Review] GUI - Login with GitHub #876

Merged

8 tasks

shanalikhan mentioned this issue May 20, 2019

Use webviews to show the errors. #864

Open

shanalikhan pinned this issue Jun 24, 2019

shanalikhan modified the milestones: Backlog, v3.4.0 Jun 25, 2019

shanalikhan added the fixed label Jul 1, 2019

shanalikhan pushed a commit that referenced this issue Jul 1, 2019

#506

6d6b08e

* Fix webpack build process * Only ignore warning from express

shanalikhan pushed a commit that referenced this issue Jul 2, 2019

#506

c8523b9

shanalikhan pushed a commit that referenced this issue Jul 2, 2019

#506

632b6ae

* Add button to download public gist * Download after getting public gist

shanalikhan pushed a commit that referenced this issue Jul 5, 2019

#506

d9edf09

This was referenced Jul 11, 2019

Display List of Available Gist On Connected User Account #308

Closed

open settings gist to browser via command #749

Closed

shanalikhan unpinned this issue Jul 15, 2019

issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Jul 18, 2019

shanalikhan closed this as completed Jul 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature request : add a login(account) option to sync all settings using account #506

Feature request : add a login(account) option to sync all settings using account #506

kanatkubash commented Mar 5, 2018 •

edited by issuehunt-oss bot

Loading

arnohovhannisyan has been rewarded.

Backers (Total: $318.00)

Submitted pull Requests

Tips

shanalikhan commented Mar 22, 2018

IssueHuntBot commented Sep 14, 2018

IssueHuntBot commented Sep 17, 2018

shanalikhan commented Sep 19, 2018

IssueHuntBot commented Sep 20, 2018

shanalikhan commented Oct 11, 2018

zhangzhishan commented Oct 13, 2018

shanalikhan commented Oct 19, 2018

shanalikhan commented Oct 30, 2018

PicchiKevin commented Jan 31, 2019

IssueHuntBot commented Mar 18, 2019

shanalikhan commented Mar 18, 2019

aashutoshrathi commented Mar 18, 2019

shanalikhan commented Mar 18, 2019

janat08 commented Mar 26, 2019 •

edited

Loading

kanatkubash commented Mar 26, 2019

janat08 commented Mar 26, 2019

janat08 commented Mar 26, 2019

kanatkubash commented Mar 29, 2019

qti3e commented Jun 30, 2019 •

edited

Loading

janat08 commented Jun 30, 2019 •

edited

Loading

shanalikhan commented Jul 15, 2019

issuehunt-oss bot commented Jul 18, 2019

shanalikhan commented Jul 18, 2019

Feature request : add a login(account) option to sync all settings using account #506

Feature request : add a login(account) option to sync all settings using account #506

Comments

kanatkubash commented Mar 5, 2018 • edited by issuehunt-oss bot Loading

arnohovhannisyan has been rewarded.

Backers (Total: $318.00)

Submitted pull Requests

Tips

shanalikhan commented Mar 22, 2018

IssueHuntBot commented Sep 14, 2018

IssueHuntBot commented Sep 17, 2018

shanalikhan commented Sep 19, 2018

IssueHuntBot commented Sep 20, 2018

shanalikhan commented Oct 11, 2018

zhangzhishan commented Oct 13, 2018

shanalikhan commented Oct 19, 2018

shanalikhan commented Oct 30, 2018

PicchiKevin commented Jan 31, 2019

IssueHuntBot commented Mar 18, 2019

shanalikhan commented Mar 18, 2019

aashutoshrathi commented Mar 18, 2019

shanalikhan commented Mar 18, 2019

janat08 commented Mar 26, 2019 • edited Loading

kanatkubash commented Mar 26, 2019

janat08 commented Mar 26, 2019

janat08 commented Mar 26, 2019

kanatkubash commented Mar 29, 2019

qti3e commented Jun 30, 2019 • edited Loading

janat08 commented Jun 30, 2019 • edited Loading

shanalikhan commented Jul 15, 2019

issuehunt-oss bot commented Jul 18, 2019

shanalikhan commented Jul 18, 2019

kanatkubash commented Mar 5, 2018 •

edited by issuehunt-oss bot

Loading

janat08 commented Mar 26, 2019 •

edited

Loading

qti3e commented Jun 30, 2019 •

edited

Loading

janat08 commented Jun 30, 2019 •

edited

Loading