#668

* Throw error * Try to fix issues with getting missing
shanalikhan · Jun 11, 2019 · cbffb6c · cbffb6c
1 parent 8e129ff
commit cbffb6c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/service/pluginService.ts b/src/service/pluginService.ts
@@ -84,7 +84,9 @@ export class PluginService {
     const localList = this.CreateExtensionList();
 
     return remoteList.filter(
-      ext => !ignoredExtensions.includes(ext.name) && !localList.includes(ext)
+      ext =>
+        !ignoredExtensions.includes(ext.name) &&
+        !localList.map(e => e.name).includes(ext.name)
     );
   }
 

diff --git a/src/sync.ts b/src/sync.ts
@@ -535,11 +535,11 @@ export class Sync {
                     content,
                     ignoredExtensions
                   );
-                } catch (uncompletedExtensions) {
+                } catch (err) {
                   vscode.window.showErrorMessage(
                     localize("cmd.downloadSettings.error.removeExtFail")
                   );
-                  deletedExtensions = uncompletedExtensions;
+                  throw new Error(err);
                 }
               }