Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using unsafe #27

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Not using unsafe #27

merged 2 commits into from
Aug 5, 2021

Conversation

shamaton
Copy link
Owner

@shamaton shamaton commented Aug 5, 2021

The impact on Default(Map) Format was great, so I modified the code to suppress it.
Performance will be less, but it can use safe completely.
issue: #25

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #27 (48efb60) into master (e325f82) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   81.18%   81.29%   +0.10%     
==========================================
  Files          38       38              
  Lines        2402     2416      +14     
==========================================
+ Hits         1950     1964      +14     
  Misses        284      284              
  Partials      168      168              
Impacted Files Coverage Δ
internal/decoding/decoding.go 76.16% <100.00%> (ø)
internal/decoding/string.go 93.54% <100.00%> (+0.95%) ⬆️
internal/decoding/struct.go 78.10% <100.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e325f82...48efb60. Read the comment docs.

@shamaton shamaton merged commit a5e4750 into master Aug 5, 2021
@shamaton shamaton deleted the not_using_unsafe branch August 5, 2021 03:48
@shamaton shamaton self-assigned this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant