Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s46144603 VQVAE OASIS #478

Open
wants to merge 21 commits into
base: topic-recognition
Choose a base branch
from

Conversation

joshuamcallan
Copy link

This VQVAE analyses the OASIS brain scan dataset. The path variable in dataset.py will need to be altered to run. Also, the dataset.py should be run first, followed by modules.py, train.py and finally predict.py.

…alidate - each preprocessed by normalising by factoring by 255.
…r through vq_layer for the quantised vae and finally fed the quantised vae through the decoder for the model.
… to the train.py file and also added plots of the losses and metrics during training.
…compare original vs reconstructed images as well as calculate the structured similarity (SSIM) of these two images).
… main title and description of the problem. Some headings were also made.
…set so fixed this to sample from the test set.
…al test images vs reconstructed images. Not certain yet that they will show on github however.
…ach reconstructed image shown. All are above 0.6!
@joshuamcallan joshuamcallan deleted the topic-recognition branch October 25, 2022 12:41
@joshuamcallan joshuamcallan restored the topic-recognition branch October 25, 2022 12:45
@joshuamcallan joshuamcallan reopened this Oct 25, 2022
@joshuamcallan joshuamcallan deleted the topic-recognition branch October 25, 2022 12:53
@joshuamcallan joshuamcallan restored the topic-recognition branch October 25, 2022 12:55
@joshuamcallan joshuamcallan reopened this Oct 25, 2022
@joshuamcallan joshuamcallan deleted the topic-recognition branch October 25, 2022 13:14
@joshuamcallan joshuamcallan restored the topic-recognition branch October 25, 2022 13:16
@joshuamcallan joshuamcallan reopened this Oct 25, 2022
@SiyuLiu0329
Copy link
Collaborator

SiyuLiu0329 commented Nov 9, 2022

This is an initial inspection, no action is required at this point

  • Reconstruction: OK
  • Generation: seems to be missing prior / image generation
  • please do not commit datasets
  • readme image links broken

@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem (missing generations) -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage (no architecture) -1
Module present
Commenting, could use more -1
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe OK, broken links -2
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required, however dataset has been committed, can't merge as data in repo forever now -2
Request Description OK, more info req -2
Late submission -8 (if extension was approved, marks will be restored)

@shakes76 shakes76 added the Unmergeable Cant be merged for history or other reason label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmergeable Cant be merged for history or other reason VQVAE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants