-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs fail against Ruby 3.4 [PR attached] #535
Labels
Comments
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Dec 27, 2024
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Dec 27, 2024
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535 Ref: - https://ruby-doc.org/core-2.7.0/Thread/Backtrace/Location.html#method-i-base_label
1 task
tagliala
changed the title
Specs fail against Ruby 3.4 [PR in progress]
Specs fail against Ruby 3.4 [PR attached]
Dec 27, 2024
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Jan 7, 2025
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535 Ref: - https://ruby-doc.org/core-2.7.0/Thread/Backtrace/Location.html#method-i-base_label
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Jan 7, 2025
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535 Ref: - https://ruby-doc.org/core-2.7.0/Thread/Backtrace/Location.html#method-i-base_label
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Jan 7, 2025
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535 Ref: - https://ruby-doc.org/core-2.7.0/Thread/Backtrace/Location.html#method-i-base_label
tagliala
added a commit
to tagliala/shakapacker
that referenced
this issue
Jan 7, 2025
Caller location with `label` is being decorated with `Shakapacker::Helper#` in Ruby 3.4 This commit changes `label` to `base_label` Close shakacode#535 Ref: - https://ruby-doc.org/core-2.7.0/Thread/Backtrace/Location.html#method-i-base_label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like in 3.4
append_javascript_pack_tag
is being prefixed byShakapacker::Helper
The text was updated successfully, but these errors were encountered: