Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements, yarn link, and failure to build webpack aborts tests #862

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jun 1, 2017

This change is Reviewable

@justin808 justin808 force-pushed the justin808-ci-failures branch 2 times, most recently from 8f9b541 to 7aac168 Compare June 2, 2017 06:07
@justin808 justin808 changed the title Update .travis.yml CI improvements, yarn link, and failure to build webpack aborts tests Jun 3, 2017
@justin808 justin808 force-pushed the justin808-ci-failures branch from fed8d47 to 2b7a3d3 Compare June 3, 2017 07:19
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4349533 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 32967a6 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2d151d8 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7695263 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7695263 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling eee3762 on justin808-ci-failures into ** on master**.

@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Changes Unknown when pulling 90ddfa4 on justin808-ci-failures into ** on master**.

* Have tests exit if any error building Webpack files
* Rubocop 49.1
  * Ruby version 2.3
  * Travis updates (.travis.yml)
* Remove automated tests on Turbolinks 2.x
* All tests updated against Rails 5.1.1
* Updated to Rubocop 49.1 and Rails 5.1.1 for spec/dummy
* Update .travis.yml
* package.json remove post-install for generated apps, instead using
  Yarn Link!
* Add Rainbow to Gemfile &  update rainbow
* Tests seem to only work with selenium chrome
* rails-controller-testing gem added
* Test setup tweaks
* remove awesome_print from rails_helepr.rb
* Created truthy_presence so that we use that for possible pathname
  objects.
* Fix specs on 2.4 with truthy_presence helper
@justin808 justin808 force-pushed the justin808-ci-failures branch from 90ddfa4 to 8181f5a Compare June 4, 2017 04:54
@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Changes Unknown when pulling 8181f5a on justin808-ci-failures into ** on master**.

@justin808
Copy link
Member Author

OMG!

image

@justin808 justin808 merged commit 5b8a8e6 into master Jun 4, 2017
@justin808 justin808 deleted the justin808-ci-failures branch June 4, 2017 06:13
@justin808 justin808 mentioned this pull request Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants